public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: William Hu <purplearmadillo77@proton.me>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: Cygport Bug: "find: No such file" Errors When Packaging
Date: Sun, 18 Sep 2022 14:17:25 +0100	[thread overview]
Message-ID: <36e04564-451e-f569-4f08-6dd79901b87c@dronecode.org.uk> (raw)
In-Reply-To: <8mDrr73_tuJ35T8Yyn_WTxWpsSPecUSaqm6bGgkdd-8L0Ty4BVLJHjZD1X6yoVCSaKbzluKR5UXShhDTTy0C42Ata9HRD2nC_ZKdt3ndkJ4=@proton.me>

On 17/09/2022 22:14, William Hu via Cygwin-apps wrote:
> Hi Jon,
> 
>> I think just dropping ${mldir} would prevent cygport from detecting the
>> dependencies of an ocaml library (other ocaml libraries, or ocaml
>> itself?), but the second alternative sounds acceptable.
>>
>> Patches welcome, as always :)
> 
> Thanks for the insight! Patch attached :)

Thanks.

This change is probably safe and does what you say, but it looks like it 
could potentially misbehave when ${mldir} doesn't exist, but 
${D}/${mldir} does (a situation which probably can't occur, as it 
doesn't seem to make sense to build ocaml libraries when ocaml isn't 
installed?)

In future, please try to use git-format-patch, if possible, as that 
saves me having to write patch commentary, and ensures correct patch 
attribution.


  reply	other threads:[~2022-09-18 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 19:38 William Hu
2022-09-17 12:27 ` Jon Turney
2022-09-17 21:14   ` William Hu
2022-09-18 13:17     ` Jon Turney [this message]
2022-10-02 20:49       ` William Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36e04564-451e-f569-4f08-6dd79901b87c@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=purplearmadillo77@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).