* [cygport PATCH] Check for pythonXX-wheel when using python-wheel
@ 2023-10-27 8:41 Adam Dinwoodie
2023-10-27 17:03 ` Jon Turney
0 siblings, 1 reply; 2+ messages in thread
From: Adam Dinwoodie @ 2023-10-27 8:41 UTC (permalink / raw)
To: cygwin-apps
The python wheel package is required for building using the python-wheel
cygclass, but nothing in cygport verifies its existence, and the error
from the Python commands themselves aren't particularly helpful either.
To avoid other people wasting the time I just did trying to debug Python
build errors, check if the relevant wheel executable is installed, and
complain if it isn't.
---
cygclass/python-wheel.cygclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/cygclass/python-wheel.cygclass b/cygclass/python-wheel.cygclass
index 4f71639d..3f274b98 100644
--- a/cygclass/python-wheel.cygclass
+++ b/cygclass/python-wheel.cygclass
@@ -111,6 +111,7 @@ do
esac
check_prog_req pip${ver} python${ver//.}-pip
+ check_prog_req wheel-${ver} python${ver//.}-wheel
done
#****o* python-wheel.cygclass/PKG_NAMES (python-wheel)
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [cygport PATCH] Check for pythonXX-wheel when using python-wheel
2023-10-27 8:41 [cygport PATCH] Check for pythonXX-wheel when using python-wheel Adam Dinwoodie
@ 2023-10-27 17:03 ` Jon Turney
0 siblings, 0 replies; 2+ messages in thread
From: Jon Turney @ 2023-10-27 17:03 UTC (permalink / raw)
To: cygwin-apps, Adam Dinwoodie
On 27/10/2023 09:41, Adam Dinwoodie via Cygwin-apps wrote:
> The python wheel package is required for building using the python-wheel
> cygclass, but nothing in cygport verifies its existence, and the error
> from the Python commands themselves aren't particularly helpful either.
> To avoid other people wasting the time I just did trying to debug Python
> build errors, check if the relevant wheel executable is installed, and
> complain if it isn't.
Thanks. Applied.
Depending on the path taken to hit the error, this seems like it might
well be an oversight in 2596f685, for which I apologise.
> ---
> cygclass/python-wheel.cygclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cygclass/python-wheel.cygclass b/cygclass/python-wheel.cygclass
> index 4f71639d..3f274b98 100644
> --- a/cygclass/python-wheel.cygclass
> +++ b/cygclass/python-wheel.cygclass
> @@ -111,6 +111,7 @@ do
> esac
>
> check_prog_req pip${ver} python${ver//.}-pip
> + check_prog_req wheel-${ver} python${ver//.}-wheel
> done
>
> #****o* python-wheel.cygclass/PKG_NAMES (python-wheel)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-27 8:41 [cygport PATCH] Check for pythonXX-wheel when using python-wheel Adam Dinwoodie
2023-10-27 17:03 ` Jon Turney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).