Re: Tmux crashes on copy

Re: Tmux crashes on copy

[Yasuhiro Kimura]

Switching to cygwin-apps as my question is about .cygport file.

From: Brian Inglis via Cygwin <cygwin@cygwin.com>
Subject: Re: Tmux crashes on copy
Date: Sun, 21 Jan 2024 13:09:23 -0700

> On 2024-01-18 01:24, Takashi Yano via Cygwin wrote:
>> On Thu, 18 Jan 2024 16:37:59 +0900 (JST)
>> Yasuhiro Kimura wrote:
>>> On Wed, 17 Jan 2024 12:30:59 +0000, David Stephenson via Cygwin wrote:
> 
>>>> When using the copy function in tmux it crashes on Enter.
>>>> Steps:
>>>> ctrl-[ (enter copy mode)
>>>> Navigate to text
>>>> space (start copy)
>>>> Navigate to end of text
>>>> Enter (to select highlighted text) at this point tmux crashes
>>>> cygcheck.out (email redacted) and tmux.exe.stackdump attached
> 
> Known issue also on Fedora with tmux:
> 
> 	https://github.com/tmux/tmux/issues/3699
> 
> https://github.com/tmux/tmux/commit/b202a2f1b517a3de7141fc35fbd9e39ed5ac5284
> 
> new release not yet available - maintainer will have to apply upstream
> patch, or users will have to downgrade ncurses.
> 
> It looks like ncurses maintenance lagged, while tmux was updated; now
> ncurses is being updated, so tmux needs updated to 3.3a, with above
> patch and any prereqs.

I tried to do it locally but failed because it is difficult to select
necessary and sufficient changes. So I'm now thinking of packaging
latest snapshot of upstream repository on GitHub. And I have one
question.

Is there any .cygport file that downloads snapshot of repository on
GitHub as source archive?

I'd like to refer to it in order to package latest snapshot of tmux.

Best Regards.

---
Yasuhiro Kimura

Re: Tmux crashes on copy

[Marco Atzeri]

On 25/01/2024 10:04, Yasuhiro Kimura via Cygwin-apps wrote:
> Switching to cygwin-apps as my question is about .cygport file.
> 
> Is there any .cygport file that downloads snapshot of repository on
> GitHub as source archive?
> 
> I'd like to refer to it in order to package latest snapshot of tmux.
> 
> Best Regards.
> 
> ---
> Yasuhiro Kimura

Hi,

I am using from time to time

the baseline is using

   GIT_URI=
   GIT_REV=
   inherit git

instead of

   SRC_URI


-------------------------------------
FORGE="mpi"
NAME="octave-mpi"
VERSION=3.1.1
OV=3.1.0
RELEASE=0.3

LICENSE="GPL-3.0-or-later"
CATEGORY="Math"
SUMMARY="Forge: bindings for basic Message Passing Interface (MPI)"
DESCRIPTION="${SUMMARY}
Contributed functions for GNU Octave from octave.sourceforge.net"
HOMEPAGE="https://gnu-octave.github.io/packages/mpi"

GIT_URI="https://github.com/carlodefalco/octave-mpi"
GIT_REV="a44db30"
SRC_DIR="${PN}"
inherit git
#SRC_URI="https://github.com/carlodefalco/octave-mpi/releases/download/v${OV}/${FORGE}-${OV}.tar.gz"
#SRC_DIR="${FORGE}"
..
--------------------------------------

Re: Tmux crashes on copy

[Yasuhiro Kimura]

From: Marco Atzeri via Cygwin-apps <cygwin-apps@cygwin.com>
Subject: Re: Tmux crashes on copy
Date: Thu, 25 Jan 2024 12:11:13 +0100

> Hi,
> 
> I am using from time to time
> 
> the baseline is using
> 
>   GIT_URI=
>   GIT_REV=
>   inherit git
> 
> instead of
> 
>   SRC_URI
> 
> 
> -------------------------------------
> FORGE="mpi"
> NAME="octave-mpi"
> VERSION=3.1.1
> OV=3.1.0
> RELEASE=0.3
> 
> LICENSE="GPL-3.0-or-later"
> CATEGORY="Math"
> SUMMARY="Forge: bindings for basic Message Passing Interface (MPI)"
> DESCRIPTION="${SUMMARY}
> Contributed functions for GNU Octave from octave.sourceforge.net"
> HOMEPAGE="https://gnu-octave.github.io/packages/mpi"
> 
> GIT_URI="https://github.com/carlodefalco/octave-mpi"
> GIT_REV="a44db30"
> SRC_DIR="${PN}"
> inherit git
> #SRC_URI="https://github.com/carlodefalco/octave-mpi/releases/download/v${OV}/${FORGE}-${OV}.tar.gz"
> #SRC_DIR="${FORGE}"
> ..
> --------------------------------------

Thanks for quick reply.

By applying following changes to tmux.cygport of tmux 3.2-1, build of
tmux succeeds with latest snapshot of upstream repository.

----------------------------------------------------------------------
diff --git a/tmux.cygport b/tmux.cygport
index 8a770f9..bd33422 100644
--- a/tmux.cygport
+++ b/tmux.cygport
@@ -1,5 +1,5 @@
 NAME="tmux"
-VERSION="3.2"
+VERSION="3.3a.330"
 RELEASE="1"
 CATEGORY="Utils"
 SUMMARY="Terminal multiplexer"
@@ -13,11 +13,13 @@ placed in /tmp. Moreover tmux provides a consistent and well-documented command
 interface, with the same syntax whether used interactively, as a key binding,
 or from the shell. It offers a choice of vim or Emacs key layouts."
 HOMEPAGE="http://${PN}.github.io"
-SRC_URI="https://github.com/${PN}/${PN}/releases/download/${PV}/${P}.tar.gz"
+GIT_URI="https://github.com/${PN}/${PN}"
+GIT_REV="ea7136fb"
+inherit git
 PATCH_URI="patches/0001-fix-control-mode.patch"
 
 DEPEND="autoconf automake pkg-config libtool gettext-devel make git
-libevent-devel libncurses-devel"
+libevent-devel libncurses-devel bison"
 
 # tmux includes ncurses as <ncurses.h> and doesn't look for libncursesw
 CYGCONF_ARGS="CPPFLAGS=-I/usr/include/ncursesw LIBS=-lncursesw"
----------------------------------------------------------------------

---
Yasuhiro Kimura

Re: Tmux crashes on copy

[Jon Turney]

On 25/01/2024 11:49, Yasuhiro Kimura via Cygwin-apps wrote:
> From: Marco Atzeri via Cygwin-apps <cygwin-apps-rDBXBDvO6BXQT0dZR+AlfA@public.gmane.org>
> Subject: Re: Tmux crashes on copy
> Date: Thu, 25 Jan 2024 12:11:13 +0100
> 
[...]
> 
> Thanks for quick reply.
> 
> By applying following changes to tmux.cygport of tmux 3.2-1, build of
> tmux succeeds with latest snapshot of upstream repository.
> 
> ----------------------------------------------------------------------
> diff --git a/tmux.cygport b/tmux.cygport
> index 8a770f9..bd33422 100644
> --- a/tmux.cygport
> +++ b/tmux.cygport
> @@ -1,5 +1,5 @@
>   NAME="tmux"
> -VERSION="3.2"
> +VERSION="3.3a.330"
>   RELEASE="1"
>   CATEGORY="Utils"
>   SUMMARY="Terminal multiplexer"
> @@ -13,11 +13,13 @@ placed in /tmp. Moreover tmux provides a consistent and well-documented command
>   interface, with the same syntax whether used interactively, as a key binding,
>   or from the shell. It offers a choice of vim or Emacs key layouts."
>   HOMEPAGE="http://${PN}.github.io"
> -SRC_URI="https://github.com/${PN}/${PN}/releases/download/${PV}/${P}.tar.gz"
> +GIT_URI="https://github.com/${PN}/${PN}"
> +GIT_REV="ea7136fb"
> +inherit git
>   PATCH_URI="patches/0001-fix-control-mode.patch"
>   
>   DEPEND="autoconf automake pkg-config libtool gettext-devel make git
> -libevent-devel libncurses-devel"
> +libevent-devel libncurses-devel bison"
>   
>   # tmux includes ncurses as <ncurses.h> and doesn't look for libncursesw
>   CYGCONF_ARGS="CPPFLAGS=-I/usr/include/ncursesw LIBS=-lncursesw"
> ----------------------------------------------------------------------

Thanks.

Since this is a crash bug, which renders the package more or less 
useless, I made an NMU with these changes.


Michael,

Sorry about not pinging you before I made this change.

You don't seem to have been active for a few years. Are you still 
interesting in maintaining this package?

IF so, do you want to get pinged if/when problems crop up?

Re: Tmux crashes on copy

[Yasuhiro Kimura]

Hello,

From: Jon Turney via Cygwin-apps <cygwin-apps@cygwin.com>
Subject: Re: Tmux crashes on copy
Date: Wed, 31 Jan 2024 13:28:41 +0000

> Thanks.
> 
> Since this is a crash bug, which renders the package more or less
> useless, I made an NMU with these changes.
> 
> 
> Michael,
> 
> Sorry about not pinging you before I made this change.
> 
> You don't seem to have been active for a few years. Are you still
> interesting in maintaining this package?
> 
> IF so, do you want to get pinged if/when problems crop up?
> 

Tmux 3.4 is released.

https://github.com/tmux/tmux/releases/tag/3.4

Just FYI.

---
Yasuhiro Kimura

Re: Tmux crashes on copy

[Jon Turney]

On 14/02/2024 00:11, Yasuhiro Kimura via Cygwin-apps wrote:
> Hello,
> 
> From: Jon Turney via Cygwin-apps <cygwin-apps-rDBXBDvO6BXQT0dZR+AlfA@public.gmane.org>
> Subject: Re: Tmux crashes on copy
> Date: Wed, 31 Jan 2024 13:28:41 +0000
> 
>> Thanks.
>>
>> Since this is a crash bug, which renders the package more or less
>> useless, I made an NMU with these changes.
>>
>>
>> Michael,
>>
>> Sorry about not pinging you before I made this change.
>>
>> You don't seem to have been active for a few years. Are you still
>> interesting in maintaining this package?
>>
>> IF so, do you want to get pinged if/when problems crop up?
>>
> 
> Tmux 3.4 is released.
> 
> https://github.com/tmux/tmux/releases/tag/3.4
> 
> Just FYI.

Thanks.

I don't use tmux, so if I were to just bump the version, I'd just be 
deploying the updated package without any testing, which is something I 
try to avoid doing.

If an up-to-date and working tmux package is important to you, please 
consider if maybe you want to adopt it? (I'm assuming the existing 
maintainer has wandered off since he didn't reply, but our process 
requires me to wait a bit longer before that's assumed)

Even if you don't, maybe you would consider submitting an ssh key, so 
you can push to our package building playground, which would make it a 
bit less effort for me in future, if you submit other NMUs.

Re: Tmux crashes on copy

[ASSI]

Jon Turney via Cygwin-apps writes:
> I don't use tmux, so if I were to just bump the version, I'd just be
> deploying the updated package without any testing, which is something
> I try to avoid doing.

I do, I just built it locally (with the dud patch that doesn't actually
fix control mode backed out).

> If an up-to-date and working tmux package is important to you, please
> consider if maybe you want to adopt it? (I'm assuming the existing
> maintainer has wandered off since he didn't reply, but our process
> requires me to wait a bit longer before that's assumed).

I'd be willing to ITA tmux and do an NMU in the interim.

I've pushed the package to playground and it has built cleanly on
AppVeyor.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: ncurses version (was: Tmux crashes on copy)

[Brian Inglis]

On 2024-01-31 10:36, ASSI via Cygwin wrote:
> Jon Turney via Cygwin writes:
>> If upstream really is making multiple releases called '6.4', which
>> we're supposed to distinguish by some other means, then there aren't
>> really any good answers...

> There's only one official 6.4 release, but just about everyone packages
> one of the roughly weekly snapshots inbetween releases (depending on
> where you are looking they are also called beta versions), which are
> named 6.4-yyyymmdd upstream.  We can't have a "-" in the version number,
> hence the suggestion to replace it with a "+".

[moving discussion to -apps]

Upstream developer is Thomas Dickey at invisible-island.net so no git.

My only concern is if 6.4+20240203-1 !> 6.4-20240120 as strvercmp test beds 
disagree, presumably about the effect of the delimiter, possibly because the + 
may be treated similarly to a prefix for an RC preceding the 6.4 release?

For guidance I have looked at:

	https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/

which states that ~ prefixes pre-stable "snapshot" releases and ^ prefixes 
post-stable "snapshot" releases where . or nothing prefixes upstream bugfix or 
patch level releases, so perhaps we should just use version suffix .yyyymmdd?

I have downloaded and locally installed Fedora rpmdevtools package but Cygwin 
python rpm module seems to lack labelCompare():

$ rpmdev-vercmp 6.4+20240203-1 6.4-20240120
/usr/local/lib/python3.9/site-packages/rpm.py:15: UserWarning: The RPM Python 
bindings are not currently available via PyPI.

Please install them with your distro package manager (typically called
'python2-rpm' or 'python3-rpm'), and ensure that any virtual environments
needing the API are configured to be able to see the system site packages
directory.

   warnings.warn(warning_msg)
Traceback (most recent call last):
   File "/home/BWI/bin/rpmdev-vercmp", line 121, in <module>
     main()
   File "/home/BWI/bin/rpmdev-vercmp", line 108, in main
     rc = rpm.labelCompare((e1 or None, v1 or None, r1 or None),
AttributeError: module 'rpm' has no attribute 'labelCompare'

I also pip3 installed SAS SW rpm_vercmp which seems okay:

$ python3 -c 'import 
rpm_vercmp;print(rpm_vercmp.vercmp("6.4+20240203-1","6.4-20240120"))
'
1

and wrote a wrapper for shell script functions I found which agrees:

$ ~/src/fedora/rpm-ver.bash 6.4+20240203-1 6.4-20240120
0 6 4 20240203 1
0 6 4 20240120
6.4+20240203-1   6.4-20240120
0 6 4 20240203 1         0 6 4 20240120
sizes 5 4 max 5
20240203 != 20240120
8 ? 8
1

How are Cygwin pre-stable RC releases defined differently from post-stable 
snapshot releases and upstream patch releases?

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

Re: ncurses version

[Jon Turney]

On 31/01/2024 20:45, Brian Inglis via Cygwin-apps wrote:
> On 2024-01-31 10:36, ASSI via Cygwin wrote:
>> Jon Turney via Cygwin writes:
>>> If upstream really is making multiple releases called '6.4', which
>>> we're supposed to distinguish by some other means, then there aren't
>>> really any good answers...
> 
>> There's only one official 6.4 release, but just about everyone packages
>> one of the roughly weekly snapshots inbetween releases (depending on
>> where you are looking they are also called beta versions), which are
>> named 6.4-yyyymmdd upstream.  We can't have a "-" in the version number,
>> hence the suggestion to replace it with a "+".
> 
> [moving discussion to -apps]
> 
> Upstream developer is Thomas Dickey at invisible-island.net so no git.
> 
> My only concern is if 6.4+20240203-1 !> 6.4-20240120 as strvercmp test 
> beds disagree, presumably about the effect of the delimiter, possibly 
> because the + may be treated similarly to a prefix for an RC preceding 
> the 6.4 release?
> 
> For guidance I have looked at:
> 
>      https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> 
> which states that ~ prefixes pre-stable "snapshot" releases and ^ 
> prefixes post-stable "snapshot" releases where . or nothing prefixes 
> upstream bugfix or patch level releases, so perhaps we should just use 
> version suffix .yyyymmdd?

So, this is notionally defined here [1].

The important point there "Non-alphanumeric separators for these 
contiguous chunks are ignored" (after identifying chunks)

So '1.2.3' '1+2+3' and '1_2_3' are all equal.

[1] https://cygwin.com/packaging-package-files.html#naming

Practically, this is controlled by the version comparison which libsolv 
does, which I am expecting to also work like that.

(Perhaps naively. All the details are paged-out at the moment. I think I 
remember there's a flag which you have to give it to turn on the special 
behaviour of tilde and caret, which in any case aren't currently in the 
character set permitted for a cygwin package name)

> I have downloaded and locally installed Fedora rpmdevtools package but 
> Cygwin python rpm module seems to lack labelCompare():
> 
> $ rpmdev-vercmp 6.4+20240203-1 6.4-20240120
> /usr/local/lib/python3.9/site-packages/rpm.py:15: UserWarning: The RPM 
> Python bindings are not currently available via PyPI.

This can't be cygwin's python rpm module if it's in /usr/local/, I think?

If you have calm installed, you can use:

> $ calm-tool sort-versions 1.2.1 1.2.3 1+2+3 1_2_3 1.2.4
> 1.2.1
> 1.2.3 1+2+3 1_2_3
> 1.2.4

At this point it should be clear that 6.4+2024012 is greater than 6.4.

> How are Cygwin pre-stable RC releases defined differently from 
> post-stable snapshot releases and upstream patch releases?

Generally, I think that following [2], as linked from that, is a good 
idea. i.e.

for pre-release versions use R="0." followed by  something that's going 
to increase as prereleases do e.g. date or an incrementing ordinal and 
then a githash.

for post-releases you can increment R and add a similar identifier.

You can instead add things to V to indicate post-label snapshots, but 
there's there's a risk of coming unstuck unless the upstream versioning 
scheme is totally predicable (i.e. if you create 1.2+3 for a 
post-release fix to 1.2, and then upstream releases a 1.2a which you 
weren't expecting because they've never done it before, you're boned)

[2] https://fedoraproject.org/wiki/Package_Versioning_Examples

Re: ncurses version

[Brian Inglis]

On 2024-01-31 16:05, Jon Turney via Cygwin-apps wrote:
> On 31/01/2024 20:45, Brian Inglis via Cygwin-apps wrote:
>> On 2024-01-31 10:36, ASSI via Cygwin wrote:
>>> Jon Turney via Cygwin writes:
>>>> If upstream really is making multiple releases called '6.4', which
>>>> we're supposed to distinguish by some other means, then there aren't
>>>> really any good answers...
>>
>>> There's only one official 6.4 release, but just about everyone packages
>>> one of the roughly weekly snapshots inbetween releases (depending on
>>> where you are looking they are also called beta versions), which are
>>> named 6.4-yyyymmdd upstream.  We can't have a "-" in the version number,
>>> hence the suggestion to replace it with a "+".
>>
>> [moving discussion to -apps]
>>
>> Upstream developer is Thomas Dickey at invisible-island.net so no git.
>>
>> My only concern is if 6.4+20240203-1 !> 6.4-20240120 as strvercmp test beds 
>> disagree, presumably about the effect of the delimiter, possibly because the + 
>> may be treated similarly to a prefix for an RC preceding the 6.4 release?
>>
>> For guidance I have looked at:
>>
>>      https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
>>
>> which states that ~ prefixes pre-stable "snapshot" releases and ^ prefixes 
>> post-stable "snapshot" releases where . or nothing prefixes upstream bugfix or 
>> patch level releases, so perhaps we should just use version suffix .yyyymmdd?
> 
> So, this is notionally defined here [1].
> 
> The important point there "Non-alphanumeric separators for these contiguous 
> chunks are ignored" (after identifying chunks)
> 
> So '1.2.3' '1+2+3' and '1_2_3' are all equal.
> 
> [1] https://cygwin.com/packaging-package-files.html#naming
> 
> Practically, this is controlled by the version comparison which libsolv does, 
> which I am expecting to also work like that.
> 
> (Perhaps naively. All the details are paged-out at the moment. I think I 
> remember there's a flag which you have to give it to turn on the special 
> behaviour of tilde and caret, which in any case aren't currently in the 
> character set permitted for a cygwin package name)
> 
>> I have downloaded and locally installed Fedora rpmdevtools package but Cygwin 
>> python rpm module seems to lack labelCompare():
>>
>> $ rpmdev-vercmp 6.4+20240203-1 6.4-20240120
>> /usr/local/lib/python3.9/site-packages/rpm.py:15: UserWarning: The RPM Python 
>> bindings are not currently available via PyPI.
> 
> This can't be cygwin's python rpm module if it's in /usr/local/, I think?

Thanks for the hint Jon, maybe a pip dependency install needs removed, now works:

$ rm -f /usr/local/lib/python3.9/site-packages/rpm.py
removed '/usr/local/lib/python3.9/site-packages/rpm.py'
$ rm -rf /usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/
removed '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/INSTALLER'
removed '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/LICENSE'
removed '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/METADATA'
removed '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/RECORD'
removed '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/REQUESTED'
removed '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/WHEEL'
removed directory '/usr/local/lib/python3.9/site-packages/rpm-0.0.2.dist-info/'
$ rpmdev-vercmp 6.4+20240203-1 6.4-20240120
6.4+20240203-1 > 6.4-20240120

> If you have calm installed, you can use:
> 
>> $ calm-tool sort-versions 1.2.1 1.2.3 1+2+3 1_2_3 1.2.4
>> 1.2.1
>> 1.2.3 1+2+3 1_2_3
>> 1.2.4

Thanks for that too, also works:

$ calm-tool sort-versions 6.4+20240203-1 6.4-20240120; echo
6.4-20240120
6.4+20240203-1

> At this point it should be clear that 6.4+2024012 is greater than 6.4.
> 
>> How are Cygwin pre-stable RC releases defined differently from post-stable 
>> snapshot releases and upstream patch releases?
> 
> Generally, I think that following [2], as linked from that, is a good idea. i.e.
> 
> for pre-release versions use R="0." followed by  something that's going to 
> increase as prereleases do e.g. date or an incrementing ordinal and then a githash.
> 
> for post-releases you can increment R and add a similar identifier.
> 
> You can instead add things to V to indicate post-label snapshots, but there's 
> there's a risk of coming unstuck unless the upstream versioning scheme is 
> totally predicable (i.e. if you create 1.2+3 for a post-release fix to 1.2, and 
> then upstream releases a 1.2a which you weren't expecting because they've never 
> done it before, you're boned)
> 
> [2] https://fedoraproject.org/wiki/Package_Versioning_Examples

Saw that before and know from Debian there is a need for "epoch:" prefix there.

Made necessary changes, reran local and GH Scallywag builds, and uploaded 
unannounced test release, to check all works okay behind the scenes.
Will not push master until ready to make another stable release.

Will copy this approach going forward with other i-i.net and upstream packages 
with major.minor-date releases when updated.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry