From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Houder <houder-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
Subject: Re: [PATCH] Do not clear the prev, curr and exp fields of packagemeta. Never.
Date: Mon, 23 May 2016 13:44:00 -0000 [thread overview]
Message-ID: <44110727-fec0-caba-84f5-5e4908ee13dc@dronecode.org.uk> (raw)
In-Reply-To: <510b310a3f4f5a19abf1349216f013b3@xs4all.nl>
On 04/05/2016 13:38, Houder wrote:
> Please, submit this patch.
Thanks for the patch.
> This patch rectifies
>
> - packagemeta::ScanDownloadedFiles (package_meta.cc), and
> - packagemeta::trustp (package_meta.h)
>
> Clarification:
> Class packagemeta has "fields" prev, curr, exp and installed, which in fact
> represent the info from setup.ini/installed.db, and should never be cleared
> therefore. _Currently_ these fields are cleared in ScanDownloadedFiles() in
> order to notify that the tarball for the associated field is not available.
> This is a mistake, as it destroys relevant info (e.g. the version number of
> a version).
> To ascertain whether or not the associated tarball is available, one should
> invoke <field>.accesible().
Can you clarify a bit about the problem that this patch solves? And how
you tested that it fixes it?
next prev parent reply other threads:[~2016-05-23 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 12:39 Houder
2016-05-18 16:09 ` Corinna Vinschen
2016-05-23 13:44 ` Jon Turney [this message]
2016-05-23 15:26 ` Houder
2016-05-23 16:45 ` [PATCH] Do not clear the prev, curr and ... Minor clarification Houder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44110727-fec0-caba-84f5-5e4908ee13dc@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
--cc=houder-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).