Request for review: wavpack 5.3.0

Request for review: wavpack 5.3.0

[Yasuhiro KIMURA]

Update wavpack to 5.3.0. Patches to fix security vulnerabilties are
already included in this version. So they are removed.

wavpack.cygport
----------------------------------------------------------------------
NAME="wavpack"
VERSION=5.3.0
RELEASE=1
CATEGORY="Audio"
SUMMARY="Hybrid lossless audio codec"
DESCRIPTION="WavPack is a completely open audio compression format providing
lossless, high-quality lossy, and a unique hybrid compression mode.
Although the technology is loosely based on previous versions of
WavPack, the new version 4 format has been designed from the ground up
to offer unparalleled performance and functionality."
HOMEPAGE="http://www.wavpack.com/"
SRC_URI="http://www.wavpack.com/${NAME}-${VERSION}.tar.xz"

PKG_NAMES="${NAME} lib${NAME}1 lib${NAME}-devel"
wavpack_CONTENTS='usr/bin/*.exe usr/share/'
libwavpack1_CONTENTS="usr/bin/*-1.dll"
libwavpack_devel_CONTENTS='usr/include/ usr/lib/'
----------------------------------------------------------------------

Best Regards.

---
Yasuhiro KIMURA

Re: Request for review: wavpack 5.3.0

[Marco Atzeri]

On 12.06.2020 10:42, Yasuhiro KIMURA wrote:
> Update wavpack to 5.3.0. Patches to fix security vulnerabilties are
> already included in this version. So they are removed.
> 
> wavpack.cygport
> ----------------------------------------------------------------------
> NAME="wavpack"
> VERSION=5.3.0
> RELEASE=1
> CATEGORY="Audio"
> SUMMARY="Hybrid lossless audio codec"
> DESCRIPTION="WavPack is a completely open audio compression format providing
> lossless, high-quality lossy, and a unique hybrid compression mode.
> Although the technology is loosely based on previous versions of
> WavPack, the new version 4 format has been designed from the ground up
> to offer unparalleled performance and functionality."
> HOMEPAGE="http://www.wavpack.com/"
> SRC_URI="http://www.wavpack.com/${NAME}-${VERSION}.tar.xz"
> 
> PKG_NAMES="${NAME} lib${NAME}1 lib${NAME}-devel"
> wavpack_CONTENTS='usr/bin/*.exe usr/share/'
> libwavpack1_CONTENTS="usr/bin/*-1.dll"
> libwavpack_devel_CONTENTS='usr/include/ usr/lib/'
> ----------------------------------------------------------------------
> 
> Best Regards.
> 
> ---
> Yasuhiro KIMURA
> 

Hi Yasushira,
it builds fine.
I assume you have checked that the 3 previous patches are not
needed anymore and you have performed some type of tests.

I see the test test suites is a bit large and out of the
main source package.

It seems GTG if you can confirm the previous points

Thanks
Marco

Re: Request for review: wavpack 5.3.0

[Jon Turney]

On 12/06/2020 10:52, Marco Atzeri via Cygwin-apps wrote:
> On 12.06.2020 10:42, Yasuhiro KIMURA wrote:
>> Update wavpack to 5.3.0. Patches to fix security vulnerabilties are
>> already included in this version. So they are removed.
>>
>> wavpack.cygport
[...]
> it builds fine.
> I assume you have checked that the 3 previous patches are not
> needed anymore and you have performed some type of tests.
> 
> I see the test test suites is a bit large and out of the
> main source package.
> 
> It seems GTG if you can confirm the previous points

While doing a maintainer key update today, I notice that Marco has added 
you the maintainer for 'wavpack', but you don't have a ssh key registered.

If you are still interested in doing that, please provide a ssh key (as 
per [1]), so you can build and upload packages (as per [2]).

If not, please let me know.

Sorry about the delay.

Thanks.

[1] https://cygwin.com/packaging/key.html
[2] https://cygwin.com/package-upload.html

Re: Request for review: wavpack 5.3.0

[Jon Turney]

On 25/08/2020 16:42, Jon Turney wrote:
> On 12/06/2020 10:52, Marco Atzeri via Cygwin-apps wrote:
>> On 12.06.2020 10:42, Yasuhiro KIMURA wrote:
>>> Update wavpack to 5.3.0. Patches to fix security vulnerabilties are
>>> already included in this version. So they are removed.
>>>
>>> wavpack.cygport
> [...]
>> it builds fine.
>> I assume you have checked that the 3 previous patches are not
>> needed anymore and you have performed some type of tests.
>>
>> I see the test test suites is a bit large and out of the
>> main source package.
>>
>> It seems GTG if you can confirm the previous points
> 
> While doing a maintainer key update today, I notice that Marco has added 
> you the maintainer for 'wavpack', but you don't have a ssh key registered.
> 
> If you are still interested in doing that, please provide a ssh key (as 
> per [1]), so you can build and upload packages (as per [2]).
> 
> If not, please let me know.

No response, so I've moved this package back to orphaned, and NMU'ed 
based on the provided cygport.

> 
> Sorry about the delay.
> 
> Thanks.
> 
> [1] https://cygwin.com/packaging/key.html
> [2] https://cygwin.com/package-upload.html
>