public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Daisuke Fujimura <booleanlabel@gmail.com>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [PATCH cygport] rubygems.cygclass: set relative paths in bindir
Date: Thu, 4 May 2023 14:33:16 +0100	[thread overview]
Message-ID: <701173b5-1982-dcc3-e816-00e1d58a5e13@dronecode.org.uk> (raw)
In-Reply-To: <CAA3frXT8DpVhuM3Q=zJHS7QBg=PhVO8xrwkj=KepPRWy6-NM8w@mail.gmail.com>

On 02/05/2023 11:16, Daisuke Fujimura via Cygwin-apps wrote:
> If the `--build-root` option is specified for the `gem` command, the
> value of the `--bindir` option must be a relative path.
> 
> https://github.com/rubygems/rubygems/blob/v3.4.12/lib/rubygems/installer.rb#L678-L679
> 
> This problem seems to have occurred since this commit.
> 
> https://github.com/cygwin/cygport/commit/18bd795f82d3abeff333d35ce089dd55fa2b192c

Thanks. Applied.

I also tweaked rubygem_install() so 'gem install' failing causes an 
error, rather than continuing on regardless.


      reply	other threads:[~2023-05-04 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02 10:16 Daisuke Fujimura
2023-05-04 13:33 ` Jon Turney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=701173b5-1982-dcc3-e816-00e1d58a5e13@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=booleanlabel@gmail.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).