public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* [PATCH cygport] rubygems.cygclass: set relative paths in bindir
@ 2023-05-02 10:16 Daisuke Fujimura
  2023-05-04 13:33 ` Jon Turney
  0 siblings, 1 reply; 2+ messages in thread
From: Daisuke Fujimura @ 2023-05-02 10:16 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

If the `--build-root` option is specified for the `gem` command, the
value of the `--bindir` option must be a relative path.

https://github.com/rubygems/rubygems/blob/v3.4.12/lib/rubygems/installer.rb#L678-L679

This problem seems to have occurred since this commit.

https://github.com/cygwin/cygport/commit/18bd795f82d3abeff333d35ce089dd55fa2b192c

[-- Attachment #2: rubygems.cygclass.patch --]
[-- Type: application/octet-stream, Size: 686 bytes --]

diff --git a/cygclass/rubygem.cygclass b/cygclass/rubygem.cygclass
index 13d7b1c5..4c6b710d 100644
--- a/cygclass/rubygem.cygclass
+++ b/cygclass/rubygem.cygclass
@@ -132,7 +132,7 @@ rubygem_install() {
 #****
 	CONFIGURE_ARGS="--with-cflags='${CFLAGS} -fdebug-prefix-map=${D}${RUBYGEM_INSTDIR}=/usr/src/debug/${NAME}-${VERSION}-${RELEASE}' $RUBYGEM_CONFIGURE_ARGS $@" \
 	gem install -V --local --ignore-dependencies --document=rdoc,ri \
-		--build-root ${D} --install-dir ${RUBYGEM_DIR} --bindir ${D}$(__host_prefix)/bin \
+		--build-root ${D} --install-dir ${RUBYGEM_DIR} --bindir $(__host_prefix)/bin \
 		${RUBYGEM_NAME}-${VERSION}.gem
 
 	# used later to clean up RUBYGEM_INSTDIR

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH cygport] rubygems.cygclass: set relative paths in bindir
  2023-05-02 10:16 [PATCH cygport] rubygems.cygclass: set relative paths in bindir Daisuke Fujimura
@ 2023-05-04 13:33 ` Jon Turney
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Turney @ 2023-05-04 13:33 UTC (permalink / raw)
  To: Daisuke Fujimura, cygwin-apps

On 02/05/2023 11:16, Daisuke Fujimura via Cygwin-apps wrote:
> If the `--build-root` option is specified for the `gem` command, the
> value of the `--bindir` option must be a relative path.
> 
> https://github.com/rubygems/rubygems/blob/v3.4.12/lib/rubygems/installer.rb#L678-L679
> 
> This problem seems to have occurred since this commit.
> 
> https://github.com/cygwin/cygport/commit/18bd795f82d3abeff333d35ce089dd55fa2b192c

Thanks. Applied.

I also tweaked rubygem_install() so 'gem install' failing causes an 
error, rather than continuing on regardless.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-04 13:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 10:16 [PATCH cygport] rubygems.cygclass: set relative paths in bindir Daisuke Fujimura
2023-05-04 13:33 ` Jon Turney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).