public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>,
	Achim Gratz <Stromeko@nexgo.de>
Subject: Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip
Date: Mon, 27 Mar 2023 19:43:50 +0100	[thread overview]
Message-ID: <822a414c-be34-319e-c8d9-810cf7383e7e@dronecode.org.uk> (raw)
In-Reply-To: <b0125c19-f847-9b8a-7b44-05365e92584b@dronecode.org.uk>

On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote:
>> -        usr/lib/gcc/*/lib*|usr/lib/gcc/*/*.o)
>> +        usr/lib/gcc/*/*.o)
> 
> Why this change?
> 
>> +    local nproc=$(nproc)
> 
> This limit should probably be taken from the --jobs command line 
> parameter, if specified

Looking at this a bit more, a couple of perhaps more serious problems:

* The parallel invocations of __prepstrip_one are all appending to 
${T}/.dbgsrc.out

I don't see what makes that safe against interleaving of the output.

It's probably possible to have each instance write to a separate file 
and collect them together in __prepdebugsrc

* This patch causes several failures in the testsuite, e.g. with 
autotools/c testcase.

On a brief attempt at debugging, it this looks like it's due to not 
waiting for all the __prepstrip_one to complete before moving on, but I 
think the final wait should prevent that, so idk.

I'm not clear that invoking 'jobs', is actually doing anything, if 
job-control is turned off in a non-interactive shell?


  reply	other threads:[~2023-03-27 18:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26 18:12 Jon Turney
2023-03-27 18:43 ` Jon Turney [this message]
2023-03-30 19:49   ` Achim Gratz
2023-03-30 20:34     ` Jon Turney
2023-04-02 17:39       ` Jon Turney
2023-04-02 19:28         ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=822a414c-be34-319e-c8d9-810cf7383e7e@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=Stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).