public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* [ITP] gflags 2.2.2
@ 2023-11-16 23:20 Daisuke Fujimura
  2023-11-20 17:13 ` Jon Turney
  0 siblings, 1 reply; 6+ messages in thread
From: Daisuke Fujimura @ 2023-11-16 23:20 UTC (permalink / raw)
  To: cygwin-apps

Hello,

[ITP] A new package proposal: gflags

- gflags
- libgflags2.2
- libgflags-devel

====

SUMMARY: Commandline flags module for C++
HOMEPAGE: https://github.com/gflags/gflags
SRC_URI: https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz
LICENSE: BSD-3-Clause

====

Corresponding Linux/Unix packages are searched:
- https://repology.org/project/gflags/versions

Cygportfile:
- https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/gflags

Packages, logs:
- https://github.com/cygwin/scallywag/actions/runs/6893072156

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ITP] gflags 2.2.2
  2023-11-16 23:20 [ITP] gflags 2.2.2 Daisuke Fujimura
@ 2023-11-20 17:13 ` Jon Turney
  2023-11-25  8:55   ` Daisuke Fujimura
  0 siblings, 1 reply; 6+ messages in thread
From: Jon Turney @ 2023-11-20 17:13 UTC (permalink / raw)
  To: Daisuke Fujimura, cygwin-apps

On 16/11/2023 23:20, Daisuke Fujimura via Cygwin-apps wrote:
> Hello,
> 
> [ITP] A new package proposal: gflags
> 
> - gflags
> - libgflags2.2
> - libgflags-devel
> 
> ====
> 
> SUMMARY: Commandline flags module for C++
> HOMEPAGE: https://github.com/gflags/gflags
> SRC_URI: https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz
> LICENSE: BSD-3-Clause
> 
> ====
> 
> Corresponding Linux/Unix packages are searched:
> - https://repology.org/project/gflags/versions
> 
> Cygportfile:
> - https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/gflags
> 
> Packages, logs:
> - https://github.com/cygwin/scallywag/actions/runs/6893072156
> 

Looks good.

I've added this to your packages.

The one question I have is about what 'gflags_completions.sh' is for? Is 
this a helper for scripts other packages using gflags might install in 
/etc/bash_completion.d/, or an example? or generally useful?


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ITP] gflags 2.2.2
  2023-11-20 17:13 ` Jon Turney
@ 2023-11-25  8:55   ` Daisuke Fujimura
  2023-12-03 15:06     ` Jon Turney
  0 siblings, 1 reply; 6+ messages in thread
From: Daisuke Fujimura @ 2023-11-25  8:55 UTC (permalink / raw)
  To: cygwin-apps

> The one question I have is about what 'gflags_completions.sh' is for? Is
> this a helper for scripts other packages using gflags might install in
> /etc/bash_completion.d/, or an example? or generally useful?

gflags_completions.sh is a script that generates completions for
options supported by gflags.

- https://stackoverflow.com/questions/32555861/how-to-get-bash-tab-completions-for-your-own-project-with-gflags

Also, since major distributions such as arch and fedora include this
script in their packages, we decided it would be better to include it
in the cygwin package as well.

- https://archlinux.org/packages/extra/x86_64/gflags/files/
- https://src.fedoraproject.org/rpms/gflags/blob/rawhide/f/gflags.spec

However, perhaps this should be included in runtime or development.


On Tue, Nov 21, 2023 at 2:13 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 16/11/2023 23:20, Daisuke Fujimura via Cygwin-apps wrote:
> > Hello,
> >
> > [ITP] A new package proposal: gflags
> >
> > - gflags
> > - libgflags2.2
> > - libgflags-devel
> >
> > ====
> >
> > SUMMARY: Commandline flags module for C++
> > HOMEPAGE: https://github.com/gflags/gflags
> > SRC_URI: https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz
> > LICENSE: BSD-3-Clause
> >
> > ====
> >
> > Corresponding Linux/Unix packages are searched:
> > - https://repology.org/project/gflags/versions
> >
> > Cygportfile:
> > - https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/gflags
> >
> > Packages, logs:
> > - https://github.com/cygwin/scallywag/actions/runs/6893072156
> >
>
> Looks good.
>
> I've added this to your packages.
>
> The one question I have is about what 'gflags_completions.sh' is for? Is
> this a helper for scripts other packages using gflags might install in
> /etc/bash_completion.d/, or an example? or generally useful?
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ITP] gflags 2.2.2
  2023-11-25  8:55   ` Daisuke Fujimura
@ 2023-12-03 15:06     ` Jon Turney
  2023-12-04 11:01       ` Daisuke Fujimura
  0 siblings, 1 reply; 6+ messages in thread
From: Jon Turney @ 2023-12-03 15:06 UTC (permalink / raw)
  To: Daisuke Fujimura, cygwin-apps

On 25/11/2023 08:55, Daisuke Fujimura via Cygwin-apps wrote:
>> The one question I have is about what 'gflags_completions.sh' is for? Is
>> this a helper for scripts other packages using gflags might install in
>> /etc/bash_completion.d/, or an example? or generally useful?
> 
> gflags_completions.sh is a script that generates completions for
> options supported by gflags.
> 
> - https://stackoverflow.com/questions/32555861/how-to-get-bash-tab-completions-for-your-own-project-with-gflags
> 
> Also, since major distributions such as arch and fedora include this
> script in their packages, we decided it would be better to include it
> in the cygwin package as well.
> 
> - https://archlinux.org/packages/extra/x86_64/gflags/files/
> - https://src.fedoraproject.org/rpms/gflags/blob/rawhide/f/gflags.spec
> 
> However, perhaps this should be included in runtime or development.

Thanks.  That makes perfect sense.

Yeah, it seems like perhaps it should be with the runtime, I think.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ITP] gflags 2.2.2
  2023-12-03 15:06     ` Jon Turney
@ 2023-12-04 11:01       ` Daisuke Fujimura
  2023-12-05 13:04         ` Jon Turney
  0 siblings, 1 reply; 6+ messages in thread
From: Daisuke Fujimura @ 2023-12-04 11:01 UTC (permalink / raw)
  To: cygwin-apps

Thank you for your review.

I will merge the documentation and scripts into the runtime package.

gflags.cygport diff :
https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=3d92ec96da0cfb58ffee465eb65eec2f0b923f19

CI : https://github.com/cygwin/scallywag/actions/runs/7085452227


On Mon, Dec 4, 2023 at 12:06 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 25/11/2023 08:55, Daisuke Fujimura via Cygwin-apps wrote:
> >> The one question I have is about what 'gflags_completions.sh' is for? Is
> >> this a helper for scripts other packages using gflags might install in
> >> /etc/bash_completion.d/, or an example? or generally useful?
> >
> > gflags_completions.sh is a script that generates completions for
> > options supported by gflags.
> >
> > - https://stackoverflow.com/questions/32555861/how-to-get-bash-tab-completions-for-your-own-project-with-gflags
> >
> > Also, since major distributions such as arch and fedora include this
> > script in their packages, we decided it would be better to include it
> > in the cygwin package as well.
> >
> > - https://archlinux.org/packages/extra/x86_64/gflags/files/
> > - https://src.fedoraproject.org/rpms/gflags/blob/rawhide/f/gflags.spec
> >
> > However, perhaps this should be included in runtime or development.
>
> Thanks.  That makes perfect sense.
>
> Yeah, it seems like perhaps it should be with the runtime, I think.
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ITP] gflags 2.2.2
  2023-12-04 11:01       ` Daisuke Fujimura
@ 2023-12-05 13:04         ` Jon Turney
  0 siblings, 0 replies; 6+ messages in thread
From: Jon Turney @ 2023-12-05 13:04 UTC (permalink / raw)
  To: Daisuke Fujimura, cygwin-apps

On 04/12/2023 11:01, Daisuke Fujimura via Cygwin-apps wrote:
> Thank you for your review.
> 
> I will merge the documentation and scripts into the runtime package.
> 
> gflags.cygport diff :
> https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=3d92ec96da0cfb58ffee465eb65eec2f0b923f19
> 
> CI : https://github.com/cygwin/scallywag/actions/runs/7085452227
> 

That looks fine. Thanks!


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-12-05 13:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-16 23:20 [ITP] gflags 2.2.2 Daisuke Fujimura
2023-11-20 17:13 ` Jon Turney
2023-11-25  8:55   ` Daisuke Fujimura
2023-12-03 15:06     ` Jon Turney
2023-12-04 11:01       ` Daisuke Fujimura
2023-12-05 13:04         ` Jon Turney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).