public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: ASSI <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: Re: [cygport] enabling a replacement for "objdump -d -l"
Date: Mon, 11 Mar 2024 20:35:08 +0100	[thread overview]
Message-ID: <87il1smuj7.fsf@Gerda.invalid> (raw)
In-Reply-To: <3f1057a0-1dd5-4736-bdf9-14071c1f27b1@dronecode.org.uk> (Jon Turney via Cygwin-apps's message of "Mon, 26 Feb 2024 19:29:43 +0000")

Jon Turney via Cygwin-apps writes:
> Thanks, this is great!

You're welcome.

> Please, please make a patch with git format-patch, which I can then
> just apply.

You can always just pull it in from my repo… when it's ready.

> Fifty lines of perl with no comments! This is just line noise to me
> unless I spend lots of time staring at it :)

That's what you get from an experiment that went rather more well than
planned.

> Seriously, this should at least say "I'm running objdump -Wl to dump
> out the .debug_line section containing DWARF XYZ information.
>
> Then maybe some comments about what assumptions it's making about the
> human-readable output it's parsing.

So you're asking for a manpage, really.  Should be doable with enough
round tuits.

> cygport goes to some lengths to identify the correct objdump to use
> when cross-building, so it should probably should be used here (passed
> in as an arg?), rather than assuming it's /usr/bin/objdump.

Yes, either that or using whatever variable cygport sets up with the
correct objdump.

> What this line is doing is obvious, the rest of this block, not so much.

Nothing to see here, move along… :-P

> You might also like to touch on why we bother looking at the line
> number information at all, rather than just producing a (filtered)
> list of all the pathnames mentioned?

I was using this to figure out why the "objdump -d -l" was missing some
of the file names I was seeing (in general, again, it comes to the same
set of files in the end).

> If you're going to keep this (which you probably should), perhaps it
> should be under some 'if (DEBUG)' conditional.

Yeah, can do if I use GetOpt::Long, which I should probably do anyway
just in case this gets extended later on.

> DWARF_PARSE should be mentioned in the documentation for cygport.conf

Yes.

> Since the helper script will be installed, it could be made a boolean.

Out of habit grown over decades, I always keep an escape hatch for using
local (modified) copies in such scripts.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

  reply	other threads:[~2024-03-11 19:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18 19:51 ASSI
2024-02-20  3:42 ` Marco Atzeri
2024-02-20 18:21   ` ASSI
2024-02-26 19:29 ` Jon Turney
2024-03-11 19:35   ` ASSI [this message]
2024-03-12 17:41     ` Jon Turney
2024-03-12 17:49       ` ASSI
2024-03-12 21:39         ` Brian Inglis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il1smuj7.fsf@Gerda.invalid \
    --to=stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).