public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: Re: bug in procps-ng
Date: Thu, 14 Mar 2019 20:25:00 -0000	[thread overview]
Message-ID: <87sgvpqk3o.fsf@Rainer.invalid> (raw)
In-Reply-To: <87pnquk5g7.fsf@Rainer.invalid> (Achim Gratz's message of "Wed,	13 Mar 2019 19:14:00 +0100")

Achim Gratz writes:
> That was an exercise in futility.  Procps uses system macros to
> dissemble the major/minor devices, so of course it's doing the right
> thing on Cygwin while using Cygwin macros (I think these are actually
> inline functions now).

Actually, it didn't -- but I patched it to do so now.

We should think a bit about whether or not Cygwin should conform to the
/proc/…/stat definition of Linux with it's peculiar bit allotment for
the major/minor device numbers, in which case I'll have to change to a
versioned #ifdef (I don't particularly want to use a runtime version
check).

> But your assertion that it should use stat for
> finding the tty is probably wrong, there's Cygwin specific code that
> looks at /dev/ctty:
>
> https://gitlab.com/procps-ng/procps/blob/master/proc/devname.c#L303
>
> That's used in addition to code that would correctly determine the
> devices fromt the stat info, so at the moment I have no idea where the
> wheels fall off that wagon.

I still don't know where the bug is in the current package, as just
building the current version (without my patch that removes the function
that uses /proc/ctty) also works correctly.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

  reply	other threads:[~2019-03-14 20:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 17:03 Corinna Vinschen
2019-03-13  4:55 ` Brian Inglis
2019-03-13 10:28   ` Corinna Vinschen
2019-03-13 18:14     ` Achim Gratz
2019-03-14 20:25       ` Achim Gratz [this message]
2019-03-15 11:52         ` Corinna Vinschen
2019-03-15 16:05           ` Achim Gratz
2019-03-15 20:42             ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgvpqk3o.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).