public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* [PATCH] calm
@ 2017-11-04 16:14 Achim Gratz
  2017-11-09 13:15 ` Jon Turney
  0 siblings, 1 reply; 3+ messages in thread
From: Achim Gratz @ 2017-11-04 16:14 UTC (permalink / raw)
  To: cygwin-apps


Make a failure to chmod the setup.ini file to mode 644 non-fatal.

--- origsrc/calm/calm/package.py	2017-11-04 17:08:36.000000000 +0100
+++ src/calm/calm/package.py	2017-11-04 17:10:43.428620700 +0100
@@ -728,8 +728,10 @@ def write_setup_ini(args, packages, arch
     logging.debug('writing %s' % (args.inifile))
 
     with open(args.inifile, 'w') as f:
-        os.fchmod(f.fileno(), 0o644)
-
+        try:
+            os.fchmod(f.fileno(), 0o644)
+        except (OSError):
+            pass
         tz = time.time()
         # write setup.ini header
         print(textwrap.dedent('''\


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] calm
  2017-11-04 16:14 [PATCH] calm Achim Gratz
@ 2017-11-09 13:15 ` Jon Turney
  2017-11-09 18:03   ` Achim Gratz
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Turney @ 2017-11-09 13:15 UTC (permalink / raw)
  To: cygwin-apps

On 04/11/2017 16:14, Achim Gratz wrote:
> Make a failure to chmod the setup.ini file to mode 644 non-fatal.

Thanks.

Applied, with a bit of tweaking, as I think this is in the wrong place.

We shouldn't be chmoding the output of mksetupini at all, only calm 
needs to ensure that the setup.ini file is world-readable.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] calm
  2017-11-09 13:15 ` Jon Turney
@ 2017-11-09 18:03   ` Achim Gratz
  0 siblings, 0 replies; 3+ messages in thread
From: Achim Gratz @ 2017-11-09 18:03 UTC (permalink / raw)
  To: cygwin-apps

Jon Turney writes:
> Applied, with a bit of tweaking, as I think this is in the wrong place.

As long as I don't have to patch calm whenever it gets an update anymore
I'm happy.

BTW, I don't see it one sware yet?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-09 18:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-04 16:14 [PATCH] calm Achim Gratz
2017-11-09 13:15 ` Jon Turney
2017-11-09 18:03   ` Achim Gratz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).