Re: [PATCH] make setup mirror list more like web page not just urls

[Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>]

[-- Attachment #1: Type: text/plain, Size: 2625 bytes --]

On 2017-11-20 15:59, Ken Brown wrote:
> On 11/20/2017 4:30 PM, Brian Inglis wrote:
>> On 2017-11-17 06:53, Jon Turney wrote:
>> On 11/17/2017 8:48 AM, Ken Brown wrote:
>>> On 15/11/2017 21:35, Brian Inglis wrote:
> The issue of recognizing a URL that's already in the list is not fixed. Here's
> what I tried:
> 
> I ran setup with the last mirror (as stored in /etc/setup/setup.rc) being
> http://mirrors.kernel.org/sourceware/cygwin/.  The resulting mirror list display
> contained the following, highlighted:
>
>   Org - Kernel - http://mirrors.kernel.org
> 
> So setup didn't recognize that http://mirrors.kernel.org/sourceware/cygwin/ was
> already in the list, displayed as
> 
>   United States - California - http://mirrors.kernel.org

Should have been working so I added more LOG_BABBLE and it looks like setup.rc
is processed at the start as you would expect, but it is merged into empty site
lists, as mirrors.lst is downloaded only after you say you can, and proxy
settings, in a separate download thread: see attached.
And do you know where the cached list comes from - that seems to keep old
mirrors around from testing, but I can't find any cached list with the test
mirrors appearing in the list - I would expect that to come from setup.rc - but
appears to be loaded when mirrors.lst is.
So we need to defer adding the last mirror with some kind of lazy evaluation
hooked after cached mirrors and/or mirrors.lst is available.
If we have a setup.rc, I would expect the cached mirrors site list loaded from
there at startup, before the last mirror is merged (and found!).
Can make those changes but would like ny assumptions questioned, corrected, or
validated!

> Also, I don't like the fake 'area' and 'location' fields for user-added URLs. 
> For example, "Org" and "Kernel" are startling in the display above and add no
> information to the plain URL.  Another example is my own personal repository,
> http://sanibeltranquility.com/cygwin, which displays as
> 
>   Com - Sanibeltranquility - http://sanibeltranquility.com

Removed and defaulted both to " Unknown " - would sort to top as " Unknown  -
Unknown  - ...".

> I would rather see the area and location left blank, or perhaps replaced by
> "Unknown".  A third alternative would be to replace "Area - Location" by
> "User-added" or something similar.

Changed to " Saved " and " Mirror " and " User " and " Added " - sorts to top as
" Saved  -  Mirror  - ..." and " User  -  Added  - ..." - could make them a
single entry, but want to get mirror site list handling working first.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

[-- Attachment #2: setup.log.full.txt --]
[-- Type: text/plain, Size: 803 bytes --]

2017/11/22 01:09:17 Starting cygwin install, version 2.882-4-gdcbcbe
2017/11/22 01:09:17 User has backup/restore rights
Checking site: http://mirror.cpsc.ucalgary.ca/mirror/cygwin.com/
Merging site: http://mirror.cpsc.ucalgary.ca/mirror/cygwin.com/
2017/11/22 01:09:17 Current Directory: C:/usr/local/cygwin64/var/cache/setup/packages
2017/11/22 01:09:17 Could not open service McShield for query, start and stop. McAfee may not be installed, or we don't have access.
2017/11/22 01:09:19 source: network install
2017/11/22 01:09:20 root: C:\usr\local\cygwin64 system
2017/11/22 01:09:20 Selected local directory: C:/usr/local/cygwin64/var/cache/setup/packages
2017/11/22 01:09:21 net: Direct
Loaded cached mirror list
Fetched URL: http://cygwin.com/mirrors.lst
2017/11/22 01:09:25 Ending cygwin install