public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH] make setup mirror list more like web page not just urls
Date: Sun, 19 Nov 2017 20:24:00 -0000	[thread overview]
Message-ID: <a0da4407-7996-39d4-d55e-f44130c7c711@cornell.edu> (raw)
In-Reply-To: <d99921d9-5e12-4b56-484a-0de2071207e5@cornell.edu>

On 11/17/2017 8:48 AM, Ken Brown wrote:
> which that fails.  Also, you shouldn't be relying on the servername 
> field being filled in.

One further comment about the servername field: AFAICT, the only use 
that's made of this field is to distinguish "official" mirrors (those 
listed in mirrors.lst, either now or in the past) from sites added by 
the user.  See 'check_dropped_mirrors()' and 'write_cache_list()' in 
site.cc.

I find this confusing, and it apparently threw Brian off also. 
Moreover, it seems to be undocumented.  I suggest either documenting 
this or changing it.  My preference is to change it, but I'm still 
thinking about how to best do that.  I'll probably send a patch later.

Ken

  reply	other threads:[~2017-11-19 20:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 21:35 Brian Inglis
2017-11-17 13:48 ` Ken Brown
2017-11-19 20:24   ` Ken Brown [this message]
2017-11-17 13:53 ` Jon Turney
2017-11-20 21:30   ` Brian Inglis
2017-11-20 22:59     ` Ken Brown
2017-11-20 23:02       ` Ken Brown
2017-11-22 16:48         ` Brian Inglis
2017-11-22 16:42       ` Brian Inglis
2017-11-23 21:07         ` Ken Brown
2017-11-24  6:23           ` Brian Inglis
2017-11-24 16:21             ` Ken Brown
2017-11-24 21:48               ` Brian Inglis
2017-11-25 16:49                 ` Ken Brown
2017-11-25 17:44                   ` Brian Inglis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0da4407-7996-39d4-d55e-f44130c7c711@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).