Re: cmus

[Jon Turney <jon.turney@dronecode.org.uk>]

On 23/10/2021 19:01, Federico Kircheis via Cygwin-apps wrote:
> On 23/10/2021 17.39, Oliver Schoede wrote:
>> On Fri, 22 Oct 2021 15:06:46 +0200
>> Federico Kircheis via Cygwin-apps 
>> <cygwin-apps-rDBXBDvO6BXQT0dZR+AlfA@public.gmane.org> wrote:
>>>
>>> Hello to everyone,
>>>
>>> I'm interested in becoming a package maintainer for the program cmus.
>>>
>>
>> Very cool! My go-to music player, been using it for years, also in
>> Cygwin. ;) It's actually one of the reasons I started using it, knew it
>> from Linux and there being no port, building it on Windows turned out
>> easier in Cygwin. There was no WSL yet. An actual package is another
>> story of course, but if there's a problem and I could possibly be of any
>> help feel free to ask.
>>
>> Looks like you appended the wrong .hint file.
>>
>> Best regards,
>> Oliver
>>
> 
> Let me try it again with the attachment...
> 
> Cool to know I'm not the only one using it under Windows :)
> 
> I did not notice any issue, but I'm just a casual user, thank you for 
> proposing to help, I'll keep it in mind ;)

Thanks.

I've added 'cmus' to your list of packages.

A few small comments on the cygport:

> # cmus.cygport
> NAME="cmus"
> VERSION=2.9.1
> TAG=2.9.1

Why not just use ${VERSION} throughout?

> RELEASE=1
> SUMMARY="cmus is a small, fast and powerful console music player for Unix-like operating systems."
> DESCRIPTION="cmus is a lightweight ncurses music player. It supports various output methods by using dynamically-loaded output plugins."
> CATEGORY="Audio"
> 
> HOMEPAGE="https://cmus.github.io/"
> SRC_URI="https://github.com/cmus/cmus/archive/v${TAG}.tar.gz"
> SRC_DIR="cmus-${TAG}"
> 
> DEPEND="libncurses-devel libmad-devel libvorbis-devel flac-devel"

DEPEND is deprecated, please use BUILD_REQUIRES instead

> REQUIRES="libncursesw10 libmad0 libvorbis flac"
> 
> PKG_NAMES="cmus"
> 
> src_compile() {
> 	lndirs
> 	cd ${B}
> 
> 	sh ./configure \
> 		CONFIG_MAD=y CONFIG_VORBIS=y CONFIG_FLAC=y \
> 		prefix=/usr bindir=/usr/bin libdir=/usr/lib datadir=/usr/share mandir=/usr/share/man
> 
> 	cygmake CC="${CC}" CXX="${CXX}" AR="${AR}" RANLIB="${RANLIB}" STRIP=/usr/bin/true

I'm not sure any of these env vars are needed (and something here seems 
to cause me some problem with "undefined reference to `xstrndup'" when 
linking)

> }
> 
> 
> #src_install() {

Please drop these commented out lines.

> #	cd ${B}
> #	cyginstall
> #}
> 
> #src_test() {
> #	# There is no test suite yet
> #	:
> #}