From: Federico Kircheis <federico.kircheis@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: cmus
Date: Sun, 31 Oct 2021 20:00:53 +0100 [thread overview]
Message-ID: <a416ec43-ed67-6efa-9059-819ed76200ea@gmail.com> (raw)
In-Reply-To: <96f80d13-0bd5-70be-8ada-f813838a36a3@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 3645 bytes --]
On 31/10/2021 16.29, Jon Turney wrote:
> On 23/10/2021 19:01, Federico Kircheis via Cygwin-apps wrote:
>> On 23/10/2021 17.39, Oliver Schoede wrote:
>>> On Fri, 22 Oct 2021 15:06:46 +0200
>>> Federico Kircheis via Cygwin-apps
>>> <cygwin-apps-rDBXBDvO6BXQT0dZR+AlfA@public.gmane.org> wrote:
>>>>
>>>> Hello to everyone,
>>>>
>>>> I'm interested in becoming a package maintainer for the program cmus.
>>>>
>>>
>>> Very cool! My go-to music player, been using it for years, also in
>>> Cygwin. ;) It's actually one of the reasons I started using it, knew it
>>> from Linux and there being no port, building it on Windows turned out
>>> easier in Cygwin. There was no WSL yet. An actual package is another
>>> story of course, but if there's a problem and I could possibly be of any
>>> help feel free to ask.
>>>
>>> Looks like you appended the wrong .hint file.
>>>
>>> Best regards,
>>> Oliver
>>>
>>
>> Let me try it again with the attachment...
>>
>> Cool to know I'm not the only one using it under Windows :)
>>
>> I did not notice any issue, but I'm just a casual user, thank you for
>> proposing to help, I'll keep it in mind ;)
>
> Thanks.
>
> I've added 'cmus' to your list of packages.
>
> A few small comments on the cygport:
>
>> # cmus.cygport
>> NAME="cmus"
>> VERSION=2.9.1
>> TAG=2.9.1
>
> Why not just use ${VERSION} throughout?
>
Good point
>> RELEASE=1
>> SUMMARY="cmus is a small, fast and powerful console music player for
>> Unix-like operating systems."
>> DESCRIPTION="cmus is a lightweight ncurses music player. It supports
>> various output methods by using dynamically-loaded output plugins."
>> CATEGORY="Audio"
>>
>> HOMEPAGE="https://cmus.github.io/"
>> SRC_URI="https://github.com/cmus/cmus/archive/v${TAG}.tar.gz"
>> SRC_DIR="cmus-${TAG}"
>>
>> DEPEND="libncurses-devel libmad-devel libvorbis-devel flac-devel"
>
> DEPEND is deprecated, please use BUILD_REQUIRES instead
>
Ah, did not know it.
IF it's deprecated, unless I did not see it, is there any type of
warning when executing cygport?
If not, it would be a nice addition, so that automatically packagers are
aware of it.
BUILD_REQUIRES is a much better name, I'm going to use it immediately.
>> REQUIRES="libncursesw10 libmad0 libvorbis flac"
>>
>> PKG_NAMES="cmus"
>>
>> src_compile() {
>> lndirs
>> cd ${B}
>>
>> sh ./configure \
>> CONFIG_MAD=y CONFIG_VORBIS=y CONFIG_FLAC=y \
>> prefix=/usr bindir=/usr/bin libdir=/usr/lib datadir=/usr/share
>> mandir=/usr/share/man
>>
>> cygmake CC="${CC}" CXX="${CXX}" AR="${AR}" RANLIB="${RANLIB}"
>> STRIP=/usr/bin/true
>
> I'm not sure any of these env vars are needed (and something here seems
> to cause me some problem with "undefined reference to `xstrndup'" when
> linking)
>
I have to admit that I've copy-pasted the cygmake line from another
cygport, probably also in that other package it's not necessary.
I've built (modulo errors) the packages in a "clean" environment, ie a
cygwin installation where I installed with setupx.exe
gcc,gdb,cygport,calm and the BUILD_REQUIRES packages.
I rechecked, and could not find anything related to xstrndup.
Could you share the exact error message?
I've dropped all the env vars and it does not seem to make any difference.
>> }
>>
>>
>> #src_install() {
>
> Please drop these commented out lines.
>
>> # cd ${B}
>> # cyginstall
>> #}
>>
>> #src_test() {
>> # # There is no test suite yet
>> # :
>> #}
I've reattached the cygport file, everything seems to work as before.
Before uploading, I would like to see the error you have, if possible.
[-- Attachment #2: cmus.cygport --]
[-- Type: text/plain, Size: 772 bytes --]
# cmus.cygport
NAME="cmus"
VERSION=2.9.1
RELEASE=1
SUMMARY="cmus is a small, fast and powerful console music player for Unix-like operating systems."
DESCRIPTION="cmus is a lightweight ncurses music player. It supports various output methods by using dynamically-loaded output plugins."
CATEGORY="Audio"
HOMEPAGE="https://cmus.github.io/"
SRC_URI="https://github.com/cmus/cmus/archive/v${VERSION}.tar.gz"
SRC_DIR="cmus-${VERSION}"
BUILD_REQUIRES="libncurses-devel libmad-devel libvorbis-devel flac-devel"
REQUIRES="libncursesw10 libmad0 libvorbis flac"
PKG_NAMES="cmus"
src_compile() {
lndirs
cd ${B}
sh ./configure \
CONFIG_MAD=y CONFIG_VORBIS=y CONFIG_FLAC=y \
prefix=/usr bindir=/usr/bin libdir=/usr/lib datadir=/usr/share mandir=/usr/share/man
cygmake
}
next prev parent reply other threads:[~2021-10-31 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:06 cmus Federico Kircheis
2021-10-23 15:39 ` cmus Oliver Schoede
2021-10-23 18:01 ` cmus Federico Kircheis
2021-10-31 15:29 ` cmus Jon Turney
2021-10-31 19:00 ` Federico Kircheis [this message]
2021-11-14 12:56 ` cmus Jon Turney
2021-11-14 14:22 ` cmus Federico Kircheis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a416ec43-ed67-6efa-9059-819ed76200ea@gmail.com \
--to=federico.kircheis@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).