public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: "Alois Schlögl" <alois.schloegl@gmail.com>
To: cygwin-apps@cygwin.com, Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
Subject: Re: [ITP] biosig [was: Re: newcomer issues when packaging biosig, stimfit, etc.]
Date: Tue, 18 Jan 2022 22:50:45 +0100	[thread overview]
Message-ID: <9aa0ab98-2270-0593-df1f-28bad20420f2@gmail.com> (raw)
In-Reply-To: <9e20944e-1fdd-7928-9c3b-84f5b907f011@SystematicSw.ab.ca>

[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]



Am 1/18/22 um 06:32 schrieb Brian Inglis:
> On 2022-01-17 14:44, Alois Schlögl wrote:
>> Am 1/15/22 um 21:44 schrieb Achim Gratz:
>>> Marco Atzeri writes:
>
>>>> add DIFF_EXCLUDES="Makefile" to avoid the artifact
>
>>> DISTCLEANFILES would be more appropriate it seems.
>
> DISTCLEANFILES is deleted immediately after downloading and unpacking 
> the *UPSTREAM* source:
>
>     https://cygwin.github.io/cygport/src_prep_cygpart.html#robo112
>
> "A list of files to be deleted immediately upon unpacking sources, 
> relative to $S. This is intended to be used with buildsystem-generated 
> files which are incorrectly included in the source tarball."
>
>> I tried this (see attachment), but I'm not sure this is what you meant.
>
> DIFF_EXCLUDES is a list of files generated in $S not automatically 
> excluded from the source package:
>
>     https://cygwin.github.io/cygport/pkg_pkg_cygpart.html#robo384
>
> "A list of file names, directory names, or glob patterns in $S which 
> will be excluded when creating the .src.patch file. This should be 
> used for files automatically generated in $S to avoid polluting the 
> patch.
> NOTE
> Files generated by various buildsystem infrastructures, such as 
> autoconf, automake, gettext, and libtool are already excluded 
> automatically and need not be listed here."
>


> Add to DIFF_EXCLUDES the names of any files you see after the output 
> header:
>
>>>> Creating source patches
>


Ok, thanks for these clear hints. I've now added these files as 
suggested. The revised version is attached.
Moreover, I've removed (commented) all aspects for building of 
python-biosig bindings, in order not to delay the inclusion of Biosig in 
Cygwin.
Is there anything else that need to be considered ?



Cheers,
    Alois







[-- Attachment #2: biosig.cygport --]
[-- Type: text/plain, Size: 3981 bytes --]

# package name
NAME="biosig"
VERSION=2.3.3
RELEASE=1

# .hint generation
CATEGORY="Libs,Science"
SUMMARY="Tools for biomedical signal processing."
DESCRIPTION="BioSig is an open source software library for 
biomedical signal processing, featuring for example the 
analysis of biosignals such as the electroencephalogram (EEG), 
electrocorticogram (ECoG), electrocardiogram (ECG), 
electrooculogram (EOG), electromyogram (EMG), respiration, 
and so on. Major application areas are: Neuroinformatics, 
brain-computer interfaces, neurophysiology, psychology, c
ardiovascular systems and sleep research. The aim of the 
BioSig project is to foster research in biomedical signal 
processing by providing open source software tools for many 
different applications. Generally, many concerns have to be a
ddressed in this scientific field. BioSig handles this by providing 
solutions for data acquisition, artifact processing, quality control, 
feature extraction, classification, modeling, data visualization, etc. "

# source and patch files
SRC_URI="https://sourceforge.net/projects/biosig/files/BioSig%20for%20C_C%2B%2B/src/biosig-2.3.3.src.tar.gz"

# PATCH_URI="biosig-2.3.3-fix-build.patch"

# use the standard src_compile, src_install and src_test

# PKG_NAMES="libbiosig libbiosig-devel biosig-tools python3-biosig"
PKG_NAMES="libbiosig libbiosig-devel biosig-tools"

biosig_tools_CONTENTS="
  usr/bin/save2gdf.exe
  usr/bin/physicalunits.exe
  usr/bin/biosig2gdf.exe
  usr/share/man/man1/save2gdf.1.gz  
  usr/share/man/man1/biosig2gdf.1.gz
  usr/share/man/man1/biosig_fhir.1.gz  
  usr/share/man/man1/physicalunits.1.gz

  usr/share/doc/biosig/COPYING
  usr/share/doc/biosig/README
"
# not included yet, would require libb64
# usr/share/man/biosig_fhir.1  usr/share/man/sigviewer.1


libbiosig_CONTENTS="
  usr/bin/libbiosig.dll
  usr/bin/libphysicalunits.dll
"

libbiosig_devel_CONTENTS="
  usr/include/biosig-dev.h 
  usr/include/biosig.h 
  usr/include/biosig2.h 
  usr/include/gdftime.h 
  usr/include/physicalunits.h 
  usr/include/biosig-network.h
  usr/include/mdc_ecg_codes.h

  usr/lib/libbiosig.a
  usr/lib/libbiosig.dll.a 
  usr/lib/libphysicalunits.a
  usr/lib/libphysicalunits.dll.a 
  usr/lib/pkgconfig/libbiosig.pc
"

#python3-biosig_CONTENTS="
#	dist/Biosig-2.3.3-cp39-cp39-cygwin_3_3_3_x86_64.whl
#"

DIFF_EXCLUDES="depend
  Makefile                
  biosig4c++/Makefile     
  biosig4c++/java/Makefile
  biosig4c++/mex/Makefile 
  biosig4c++/mma/Makefile 
"

# use not standard src_compile, src_install and src_test

src_compile() {
        cd ${S}
        lndirs
        cd ${B}
        cygautoreconf
        cygconf  # --prefix=/usr
	### libbiosig
	cygmake lib
	### biosig-tools w/o biosig_fhir
	cygmake -C biosig4c++ save2gdf physicalunits biosig2gdf
	### python3-biosig
	# cygmake -C biosig4c++/python wheel
	# cd ${B}/biosig4c++/python/
	# python3_distutils_compile bdist_wheel
	# python3_wheel_compile
}

src_install() {
	cd ${S}

	doinclude ${S}/biosig4c++/*.h
	
	dobin ${B}/biosig4c++/save2gdf.exe 
        # dobin ${B}/biosig4c++/biosig_fhir.exe
	dobin ${B}/biosig4c++/biosig2gdf.exe 
	dobin ${B}/biosig4c++/physicalunits.exe 
	dobin ${B}/biosig4c++/libbiosig.dll 
	dobin ${B}/biosig4c++/libphysicalunits.dll 

	dolib ${B}/biosig4c++/libbiosig.dll.a 
	dolib ${B}/biosig4c++/libbiosig.a 
	dolib ${B}/biosig4c++/libphysicalunits.dll.a 
	dolib ${B}/biosig4c++/libphysicalunits.a 

        dopkgconfig ${B}/biosig4c++/libbiosig.pc

	# doman ${S}/biosig4c++/doc/bin2rec.1
        doman ${S}/biosig4c++/doc/biosig2gdf.1
        doman ${S}/biosig4c++/doc/biosig_fhir.1
        doman ${S}/biosig4c++/doc/physicalunits.1
        doman ${S}/biosig4c++/doc/save2gdf.1

	# dowheel ${B}/biosig4c++/python/dist/Biosig-2.3.3-cp39-cp39-cygwin_3_3_3_x86_64.whl
}

src_test() {
    cd ${B}
    biosig4c++/physicalunits.exe
    biosig4c++/save2gdf.exe  --help
    # biosig4c++/biosig_fhir.exe --help
    # python -c "import biosig"
    # check_python3_module biosig
}


  reply	other threads:[~2022-01-18 21:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <99eff890-3d7f-7fa9-1f42-d8d611b92ded@gmail.com>
2022-01-08 17:41 ` newcomer issues when packaging biosig,stimfit, etc Marco Atzeri
2022-01-08 19:15   ` Marco Atzeri
2022-01-08 19:24     ` Marco Atzeri
     [not found]     ` <a3f8e657-1e1d-c582-2a07-806c6c03be02@gmail.com>
2022-01-12  5:47       ` Marco Atzeri
2022-01-12  6:16         ` Brian Inglis
2022-01-12 22:59           ` [ITP] biosig [was: Re: newcomer issues when packaging biosig, stimfit, etc.] Alois Schlögl
2022-01-14 10:09             ` Marco Atzeri
2022-01-14 21:48               ` Alois Schlögl
2022-01-15 18:01                 ` Marco Atzeri
2022-01-15 20:44                   ` Achim Gratz
2022-01-17 21:44                     ` Alois Schlögl
2022-01-18  5:32                       ` Brian Inglis
2022-01-18 21:50                         ` Alois Schlögl [this message]
2022-01-18 22:56                           ` Brian Inglis
2022-01-19  3:51                             ` Brian Inglis
2022-01-20 20:48                             ` Alois Schlögl
2022-01-21 12:53                               ` Jon Turney
2022-01-16 22:13                   ` Alois Schlögl
2022-01-22 17:52                     ` Marco Atzeri
2022-01-25 23:50                       ` Alois Schlögl
2022-01-26  4:52                         ` Marco Atzeri
2022-01-26 22:47                           ` Marco Atzeri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aa0ab98-2270-0593-df1f-28bad20420f2@gmail.com \
    --to=alois.schloegl@gmail.com \
    --cc=Brian.Inglis@SystematicSw.ab.ca \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).