public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* cmake: Cygwin dllexport/dllimport
@ 2015-08-24 18:21 Yaakov Selkowitz
  2015-08-25  6:02 ` Tony Kelman
  0 siblings, 1 reply; 2+ messages in thread
From: Yaakov Selkowitz @ 2015-08-24 18:21 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Tony,

Could you please include the attached patch (created wrt 3.2.3) with the
next release of cmake?  It is required for building KF5.

TIA,

Yaakov



[-- Attachment #2: 3.2.3-generate-export-header.patch --]
[-- Type: text/x-patch, Size: 574 bytes --]

--- origsrc/cmake-3.2.3/Modules/GenerateExportHeader.cmake	2015-06-01 10:56:08.000000000 -0500
+++ src/cmake-3.2.3/Modules/GenerateExportHeader.cmake	2015-07-21 17:03:05.027228100 -0500
@@ -268,7 +268,7 @@ macro(_DO_SET_MACRO_VALUES TARGET_LIBRAR
   get_property(type TARGET ${TARGET_LIBRARY} PROPERTY TYPE)
 
   if(NOT ${type} STREQUAL "STATIC_LIBRARY")
-    if(WIN32)
+    if(WIN32 OR CYGWIN)
       set(DEFINE_EXPORT "__declspec(dllexport)")
       set(DEFINE_IMPORT "__declspec(dllimport)")
     elseif(COMPILER_HAS_HIDDEN_VISIBILITY AND USE_COMPILER_HIDDEN_VISIBILITY)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: cmake: Cygwin dllexport/dllimport
  2015-08-24 18:21 cmake: Cygwin dllexport/dllimport Yaakov Selkowitz
@ 2015-08-25  6:02 ` Tony Kelman
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Kelman @ 2015-08-25  6:02 UTC (permalink / raw)
  To: Yaakov Selkowitz, cygwin-apps

> Could you please include the attached patch (created wrt 3.2.3) with the
> next release of cmake?  It is required for building KF5.

Can do. Should get to it within the next day or two.

-Tony


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-25  6:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-24 18:21 cmake: Cygwin dllexport/dllimport Yaakov Selkowitz
2015-08-25  6:02 ` Tony Kelman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).