public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Daisuke Fujimura <booleanlabel@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport] pkg_info.cygpart: Do not detect dependencies on itself in ruby package
Date: Fri, 24 May 2024 22:35:14 +0900	[thread overview]
Message-ID: <CAA3frXR_pFC_1vWA_YL370wEvWg-y0P-1wA1M50sLfQnbRGktQ@mail.gmail.com> (raw)
In-Reply-To: <5e4c5b9f-4f11-4ab5-984e-108393b7acb4@dronecode.org.uk>

Using cygport-0.36.9-1 with this patch merged in, it was confirmed
that a ruby-3.3.1 package could be created in the local development
environment.

Thank you for merging.

On Mon, May 6, 2024 at 11:12 PM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 03/04/2024 15:18, Daisuke Fujimura via Cygwin-apps wrote:
> > Thank you for reviewing this.
> >
> >> Can you clarify what the "failure" is here?
> >
> [...]
> >
> > /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file
> > -- rbconfig (LoadError)
> >
> [...]
>
> Thanks very much for the detailed explanation.
>
> So this is an error (or warning?) generated by invoking the
> not-yet-properly installed, just-built ruby in ${D}.
>
> I applied your patch.
>
> > On Sun, Mar 10, 2024 at 10:34 PM Jon Turney <jon.turney@dronecode.org.uk> wrote:
> >>
> >> On 16/02/2024 12:51, Daisuke Fujimura via Cygwin-apps wrote:
> >>> Attempting to create a package for ruby-3.3, but it fails when trying
> >>> to detect a dependency on itself.
> >>
> >> Thanks for this patch.
> >>
> >> Can you clarify what the "failure" is here?
> >>
> >>> To avoid this, skip them if the target is `ruby`.
> >>
> >> The second hunk seems like a removes the dependency on ruby_xy for the
> >> ruby package, which also provides ruby_xy.
> >>
> >> Historically, we've allowed self-dependencies like this, because they
> >> seem to be benign, although it seems like we could do with some generic
> >> code to suppress them
>
> ... except I added something to generically prevent a packages provides:
> appearing it it's requires:
>

      reply	other threads:[~2024-05-24 13:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 12:51 Daisuke Fujimura
2024-03-10 13:34 ` Jon Turney
2024-04-03 14:18   ` Daisuke Fujimura
2024-05-06 14:12     ` Jon Turney
2024-05-24 13:35       ` Daisuke Fujimura [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA3frXR_pFC_1vWA_YL370wEvWg-y0P-1wA1M50sLfQnbRGktQ@mail.gmail.com \
    --to=booleanlabel@gmail.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).