[ITA] ruby-gtk2 3.4.3

[ITA] ruby-gtk2 3.4.3

[Daisuke Fujimura]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hello,

====

Cygportfile:
- https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-gtk2

Packages, logs:
- https://github.com/cygwin/scallywag/actions/runs/5500133199

Changes:
- Remove patch : 3.2.4-cygwin-deps.patch
  - Deleted dependencies restored
- Add patch : 3.4.3-*.patch
  - Resolve undefined references
- Add fedora patch
- Add CFLAGS
  - rb_cData is deprecated, removed in ruby32
- Fix DEPS_PATH
  - ruby-gtk2 is inactive, it does not match the latest ruby-gnome version

[-- Attachment #2: ruby-gtk2.cygport.diff --]
[-- Type: application/octet-stream, Size: 1719 bytes --]

diff --git a/ruby-gtk2.cygport b/ruby-gtk2.cygport
index 66778b3..b99ce6d 100644
--- a/ruby-gtk2.cygport
+++ b/ruby-gtk2.cygport
@@ -1,14 +1,35 @@
 inherit rubygem
 
 NAME="ruby-gtk2"
-VERSION=3.2.9
+VERSION=3.4.3
 RELEASE=1
 CATEGORY="Ruby"
 SUMMARY="Ruby GTK+2 bindings"
 DESCRIPTION="Ruby/GTK2 is a Ruby binding of GTK+-2.x."
-HOMEPAGE="http://ruby-gnome2.sourceforge.jp/"
+HOMEPAGE="https://ruby-gnome.github.io/"
 
-PATCH_URI="3.2.4-cygwin-deps.patch"
+PATCH_URI="
+	https://src.fedoraproject.org/rpms/rubygem-gtk2/raw/rawhide/f/rubygem-gtk2-3.4.3-assign-nonzero-ID-to-relative-callback.patch
+	3.4.3-global.h.patch
+	3.4.3-rbgtkmacros.h.patch
+"
+
+BUILD_REQUIRES="libgtk2.0-devel ruby-atk ruby-cairo-devel ruby-gdk_pixbuf2 ruby-glib2-devel ruby-gobject-introspection-devel ruby-pango-devel ruby-pkg-config"
+LICENSE="LGPL-2.1-or-later"
+
+CFLAGS="${CFLAGS} -Drb_cData=rb_cObject"
+RUBYGEM_CONFIGURE_ARGS="--with-ldflags=-Wl,--out-implib=libruby-gtk2.a"
+
+src_install()
+{
+	cd ${S}
+	rubygem_install
+
+	pushd ${D}/usr/lib/pkgconfig
+	echo "" >> ${NAME}.pc
+	echo "Libs: -lruby-gtk2" >> ${NAME}.pc
+	popd
+}
 
 PKG_NAMES="${NAME} ${NAME}-devel ${NAME}-doc"
 ruby_gtk2_CONTENTS="--exclude=sample ${RUBYGEM_EXTDIR#/} ${RUBYGEM_INSTDIR#/} ${RUBYGEM_SPEC#/}"
@@ -16,4 +37,4 @@ ruby_gtk2_devel_REQUIRES="${NAME} ruby-glib2-devel libgtk2.0-devel"
 ruby_gtk2_devel_CONTENTS="usr/include/ usr/lib/lib*.a usr/lib/pkgconfig/"
 ruby_gtk2_doc_CONTENTS="${RUBYGEM_DOCDIR#/} ${RUBYGEM_INSTDIR#/}/sample/"
 
-DEPS_PATH="${RUBYGEM_EXTDIR%/*}/pango-${VERSION}:${RUBYGEM_EXTDIR%/*}/glib2-${VERSION}:${RUBYGEM_EXTDIR%/*}/cairo-*"
+DEPS_PATH="${RUBYGEM_EXTDIR%/*}/pango-*:${RUBYGEM_EXTDIR%/*}/glib2-*:${RUBYGEM_EXTDIR%/*}/cairo-*"

Re: [ITA] ruby-gtk2 3.4.3

[Jon Turney]

On 09/07/2023 15:05, Daisuke Fujimura via Cygwin-apps wrote:
> Hello,
> 
> ====
> 
> Cygportfile:
> - https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-gtk2
> 
> Packages, logs:
> - https://github.com/cygwin/scallywag/actions/runs/5500133199

Done, thanks.

> Changes:
> - Remove patch : 3.2.4-cygwin-deps.patch
>    - Deleted dependencies restored
> - Add patch : 3.4.3-*.patch
>    - Resolve undefined references
> - Add fedora patch
> - Add CFLAGS
>    - rb_cData is deprecated, removed in ruby32
> - Fix DEPS_PATH
>    - ruby-gtk2 is inactive, it does not match the latest ruby-gnome version

I don't quite understand what this last line here means? Dead upstream?

Re: [ITA] ruby-gtk2 3.4.3

[Daisuke Fujimura]

> I don't quite understand what this last line here means? Dead upstream?

Ruby/GTK2 has been removed in Ruby/GNOME 3.4.4.
- https://github.com/ruby-gnome/ruby-gnome/blob/4.1.8/NEWS.rd#L418

If this is the case, should I continue to maintain Ruby/GTK2 3.4.3?

It seems to be maintained in fedora.
- https://src.fedoraproject.org/rpms/rubygem-gtk2


On Mon, Jul 10, 2023 at 2:08 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 09/07/2023 15:05, Daisuke Fujimura via Cygwin-apps wrote:
> > Hello,
> >
> > ====
> >
> > Cygportfile:
> > - https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-gtk2
> >
> > Packages, logs:
> > - https://github.com/cygwin/scallywag/actions/runs/5500133199
>
> Done, thanks.
>
> > Changes:
> > - Remove patch : 3.2.4-cygwin-deps.patch
> >    - Deleted dependencies restored
> > - Add patch : 3.4.3-*.patch
> >    - Resolve undefined references
> > - Add fedora patch
> > - Add CFLAGS
> >    - rb_cData is deprecated, removed in ruby32
> > - Fix DEPS_PATH
> >    - ruby-gtk2 is inactive, it does not match the latest ruby-gnome version
>
> I don't quite understand what this last line here means? Dead upstream?
>
>
>

Re: [ITA] ruby-gtk2 3.4.3

[Brian Inglis]

FYI

$ cygcheck-dep -qSN ruby-gtk2
  ruby-gtk2: is recursively needed for ( alexandria ruby-goocanvas1 
ruby-gtk2-devel ruby-vte ruby-vte-devel ruby-webkit-gtk2 screenruler )

On 2023-07-12 09:11, Daisuke Fujimura via Cygwin-apps wrote:
>> I don't quite understand what this last line here means? Dead upstream?
> 
> Ruby/GTK2 has been removed in Ruby/GNOME 3.4.4.
> - https://github.com/ruby-gnome/ruby-gnome/blob/4.1.8/NEWS.rd#L418
> 
> If this is the case, should I continue to maintain Ruby/GTK2 3.4.3?
> 
> It seems to be maintained in fedora.
> - https://src.fedoraproject.org/rpms/rubygem-gtk2
> 
> 
> On Mon, Jul 10, 2023 at 2:08 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>>
>> On 09/07/2023 15:05, Daisuke Fujimura via Cygwin-apps wrote:
>>> Hello,
>>>
>>> ====
>>>
>>> Cygportfile:
>>> - https://cygwin.com/cgit/cygwin-packages/playground/tree/?h=ruby-gtk2
>>>
>>> Packages, logs:
>>> - https://github.com/cygwin/scallywag/actions/runs/5500133199
>>
>> Done, thanks.
>>
>>> Changes:
>>> - Remove patch : 3.2.4-cygwin-deps.patch
>>>     - Deleted dependencies restored
>>> - Add patch : 3.4.3-*.patch
>>>     - Resolve undefined references
>>> - Add fedora patch
>>> - Add CFLAGS
>>>     - rb_cData is deprecated, removed in ruby32
>>> - Fix DEPS_PATH
>>>     - ruby-gtk2 is inactive, it does not match the latest ruby-gnome version
>>
>> I don't quite understand what this last line here means?
-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

Re: [ITA] ruby-gtk2 3.4.3

[Jon Turney]

On 12/07/2023 16:11, Daisuke Fujimura via Cygwin-apps wrote:
>> I don't quite understand what this last line here means? Dead upstream?
> 
> Ruby/GTK2 has been removed in Ruby/GNOME 3.4.4.
> - https://github.com/ruby-gnome/ruby-gnome/blob/4.1.8/NEWS.rd#L418
> 
> If this is the case, should I continue to maintain Ruby/GTK2 3.4.3?
> 
> It seems to be maintained in fedora.
> - https://src.fedoraproject.org/rpms/rubygem-gtk2
> 

I see. Thanks for explaining.

I don't think there's anything wrong with continuing to provide that 
package, particularly if fedora does.

More broadly, there's probably some GNOME2-era stuff in the Cygwin 
distro which is not widely used and perhaps could be removed, but idk 
who is going to identify and progress that...