From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH 1/2 v2] Filter newlines from BUILD_REQUIRES
Date: Sat, 3 Dec 2022 20:39:47 +0100 [thread overview]
Message-ID: <Y4umAxFoUZzGqyTX@calimero.vinschen.de> (raw)
In-Reply-To: <a25e7053-08e2-deea-2bd0-db54c470c48b@dronecode.org.uk>
On Dec 3 18:07, Jon Turney via Cygwin-apps wrote:
> On 03/12/2022 16:19, Corinna Vinschen via Cygwin-apps wrote:
> > From: Corinna Vinschen <corinna-fFDxGeQsSAIb1SvskN2V4Q@public.gmane.org>
> >
> > BUILD_REQUIRES is added verbatim to the build-depends: line in
> > the *-src.hint file. If the cygport file defines BUILD_REQUIRES
> > with newlines, e. g.
> >
> > BUILD_REQUIRES="
> > a
> > b
> > "
> >
> > The -src.hint file is broken. Avoid this by filtering out any
> > newline's from BUILD_REQUIRES before using it in the subsequent
> > expression building the -src.hint file.
>
> Thanks.
>
> Attached is a patch I wrote taking a slightly more general approach.
Yeah, that looks much better to me.
Thanks,
Corinna
next prev parent reply other threads:[~2022-12-03 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 16:19 Corinna Vinschen
2022-12-03 18:07 ` Jon Turney
2022-12-03 19:39 ` Corinna Vinschen [this message]
2022-12-07 7:59 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4umAxFoUZzGqyTX@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).