From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Christoph Reiter <reiter.christoph@gmail.com>
Cc: cygwin-apps@cygwin.com
Subject: Re: [PATCH] peflags: add support for IMAGE_DLLCHARACTERISTICS_GUARD_CF
Date: Mon, 17 Apr 2023 11:37:07 +0200 [thread overview]
Message-ID: <ZD0TQyt9o5wmcUm2@calimero.vinschen.de> (raw)
In-Reply-To: <CAE6_+UeHtY6BaayVhVwiya9taFFKqBzJp11CxgUH9h93_SfW=g@mail.gmail.com>
Hi Christoph,
your patch looks good and I'm happy to merge it into peflags, but...
On Apr 17 09:48, Christoph Reiter via Cygwin-apps wrote:
> Jeremy noted that an option already exists in genpeimage [0] but with
> a different name, which I wasn't aware of: -c/control-flow-guard,
> instead of -g/guard-cf which I used here. I'm open to making them
> match.
yeah, given that peflags and genpeimg use the same single char
flags, it might be a good idea to follow suit.
Thanks,
Corinna
prev parent reply other threads:[~2023-04-17 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 13:11 Christoph Reiter
2023-04-17 7:48 ` Christoph Reiter
2023-04-17 9:37 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD0TQyt9o5wmcUm2@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-apps@cygwin.com \
--cc=reiter.christoph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).