From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Christoph Reiter <reiter.christoph@gmail.com>
Cc: cygwin-apps@cygwin.com
Subject: Re: [PATCH v2] peflags: add support for IMAGE_DLLCHARACTERISTICS_GUARD_CF
Date: Tue, 18 Apr 2023 09:44:16 +0200 [thread overview]
Message-ID: <ZD5KUD1E4BdlWaPS@calimero.vinschen.de> (raw)
In-Reply-To: <20230417184034.2234-1-reiter.christoph@gmail.com>
Hi Christoph,
On Apr 17 20:40, Christoph Reiter via Cygwin-apps wrote:
> This allows for setting, clearing, and displaying the value of the
> "control flow guard" dll characteristics flag.
>
> The flag for MSVC is called "/guard:cf" and the macro ends with "GUARD_CF".
> To keep things consistent, it would make sense to name the option "guard-cf".
> However, there's already "-c"/"control-flow-guard" in genpeimg for this flag,
> and genpeimg shares all other options with peflags so far.
> So, follow genpeimg and go with "-c" and "--control-flow-guard".
>
> This is motivated by mingw-w64 and llvm v16 gaining support for
> CFG (Control Flow Guard).
> ---
> Renamed the option from -g/--guard-cf to -c/--control-flow-guard
>
> peflags.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Pash pushed. I new rebase 4.6.3 release with your patch is just
building.
Thanks,
Corinna
next prev parent reply other threads:[~2023-04-18 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 18:40 Christoph Reiter
2023-04-18 7:44 ` Corinna Vinschen [this message]
2023-04-18 16:47 ` Christoph Reiter
2023-04-19 15:06 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD5KUD1E4BdlWaPS@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-apps@cygwin.com \
--cc=reiter.christoph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).