From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: Zstandard support for setup
Date: Sun, 07 Oct 2018 19:46:00 -0000 [thread overview]
Message-ID: <a48188c7-6218-21b8-eda5-d0851b33c203@dronecode.org.uk> (raw)
In-Reply-To: <87ftyr3k93.fsf@Rainer.invalid>
On 02/09/2018 18:02, Achim Gratz wrote:
> Achim Gratz writes:
>>> + using namespace std;
>>>
>>> Please don't
>>
>> That's a copy from the compress_xz files and it's used in many files
>> elsewhere. Care to explain why you'd want it removed? If there's a
>> good reason I'd tend to move this to a clean-up commit that touches all
>> those files. We should do that before hauling Zstdandard in.
>
> What an unholy mess⦠Here's that patch, only lightly tested:
> http://repo.or.cz/cygwin-setup/local.git/patch/e9802f50304f66984f6aad5544def465e9f8033b
Yeah. Thanks, and sorry for the delay.
Applied.
next prev parent reply other threads:[~2018-10-07 19:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 19:52 Achim Gratz
2018-08-12 13:28 ` Achim Gratz
2018-08-17 18:49 ` Achim Gratz
2018-08-20 18:11 ` Marco Atzeri
2018-08-20 19:54 ` Achim Gratz
2018-08-22 19:12 ` Achim Gratz
2018-08-23 20:40 ` Achim Gratz
2018-08-29 16:42 ` Jon Turney
2018-09-02 8:31 ` Achim Gratz
2018-09-02 17:03 ` Achim Gratz
2018-10-07 19:46 ` Jon Turney [this message]
2018-10-09 18:04 ` Achim Gratz
2018-10-07 22:09 ` Jon Turney
2018-10-09 18:05 ` Achim Gratz
2018-10-10 18:37 ` Achim Gratz
2018-10-13 17:19 ` Jon Turney
2018-10-14 11:29 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48188c7-6218-21b8-eda5-d0851b33c203@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).