public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Christian Franke <Christian.Franke@t-online.de>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] etckeeper 1.18.17-1
Date: Wed, 29 Jun 2022 09:55:10 +0200	[thread overview]
Message-ID: <acfc2e8f-4b58-733d-23f6-9b013e25473b@t-online.de> (raw)
In-Reply-To: <11b99205-0b36-a700-5a07-0ed35b3df641@t-online.de>

Christian Franke wrote:
> Adam Dinwoodie wrote:
> ...
>
>> I'm also vaguely pondering whether it's worth adding git as a
>> dependency.  That's not strictly right, since etckeeper doesn't *need*
>> git, but it's going to be the use case for 99.9% of users, and in the
>> absence of Cygwin having a "recommends" style dependency, just adding
>> git seems like it might be sensible.  But I'm far from convinced there.
>
> I'm also not sure and decided to add no git dependency. 99.8% of the 
> users considering to install etckeeper may already have git installed :-)
>
> The Debian package does not use "rec" but "dep (git or hg or brz or 
> darcs)" which defaults to git.
> If git is installed, the Debian postinst script runs 'etckeeper init 
> && etckeeper commit' on fresh installs. I decided to leave this to the 
> user.
>

A possible simple extension which would allow the user to choose between 
manual or automatic installation+initialization:

Provide an optional package, for example "etckeeper-git-init", which 
depends on etckeeper+git and only contains 
/etc/postinstall/etckeeper-git-init.sh which triggers new initialization 
code in /etc/postinstall/zp_zzz_etckeeper-postinstall.sh via some file 
in /var/cache/etckeeper. This code performs 'etckeeper init && etckeeper 
commit' if and only if VCS=git is selected and /etc/.git does not exist.

-- 
Regards,
Christian


  reply	other threads:[~2022-06-29  7:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 10:58 Christian Franke
2022-06-28 17:41 ` Adam Dinwoodie
2022-06-28 21:09   ` Christian Franke
2022-06-29  7:55     ` Christian Franke [this message]
2022-06-29  8:12       ` Adam Dinwoodie
2022-07-02 13:02         ` Jon Turney
2022-07-02 13:26         ` Christian Franke
2022-07-02 12:34 ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acfc2e8f-4b58-733d-23f6-9b013e25473b@t-online.de \
    --to=christian.franke@t-online.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).