From: Jon Turney <jon.turney@dronecode.org.uk>
To: Christian Franke <Christian.Franke@t-online.de>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [PATCH setup] Add perpetual support for preremove scripts
Date: Sat, 2 Jul 2022 13:35:23 +0100 [thread overview]
Message-ID: <b3c13857-9c20-8efa-6a3e-6ec66cd7c2e4@dronecode.org.uk> (raw)
In-Reply-To: <ac5b0a6d-8009-342f-cb7c-133a72fb53a7@t-online.de>
On 29/06/2022 19:35, Christian Franke wrote:
> Christian Franke wrote:
>> Jon Turney wrote:
>>> On 26/06/2022 17:33, Christian Franke wrote:
>>>> ...
>>>> This patch adds the missing functionality to run the pre-install
>>>> hook. It is limited to /etc/preremove/0p_* because there is possibly
>>>> no use case for /etc/preremove/zp_*.
>>>
>>> Thanks.
>>>
>>> I'm not sure what you mean by 'there is possibly no use case': That
>>> you don't have one currently, or that you've reasoned that there
>>> can't be one?
>>>
>>
>> I don't have one currently and found none which is useful in practice,
>> but cannot prove that there is none. If desired, I could provide a
>> patch which adds 'zp_*' support.
>>
>
> Meantime I realized that this is one of these cases where discussion may
> take longer than implementation. Attached is a patch ...
>
>
>>> ...
>>>
>>> I applied this patch.
>>>
>>
>> Thanks. I found a minor GUI issue during testing: Script filename
>> display persists during package remove phase. Fixed with attached patch.
>
> ... which should be applied on top of this last patch.
Thanks. Applied.
next prev parent reply other threads:[~2022-07-02 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 16:33 Christian Franke
2022-06-29 13:13 ` Jon Turney
2022-06-29 15:09 ` Christian Franke
2022-06-29 18:35 ` Christian Franke
2022-07-02 12:35 ` Jon Turney [this message]
2022-07-01 17:03 ` Christian Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c13857-9c20-8efa-6a3e-6ec66cd7c2e4@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Christian.Franke@t-online.de \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).