public inbox for
 help / color / mirror / Atom feed
From: Jon Turney <>
To: Christian Franke <>,
	"" <>
Subject: Re: [PATCH setup] Add perpetual support for preremove scripts
Date: Wed, 29 Jun 2022 14:13:21 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 26/06/2022 17:33, Christian Franke wrote:
> Use case: I ITP etckeeper ( which I 
> frequently use on Debian. For fully automatic operation, it requires 
> pre-install and post-install hooks, e.g:
> /etc/preremove/
> /etc/postinstall/
> This patch adds the missing functionality to run the pre-install hook. 
> It is limited to /etc/preremove/0p_* because there is possibly no use 
> case for /etc/preremove/zp_*.


I'm not sure what you mean by 'there is possibly no use case': That you 
don't have one currently, or that you've reasoned that there can't be one?

> 'class Perpetual0RemoveFindVisitor' is borrowed from and 
> modified. It still uses the ugly pre-C++11 hack to disable copy-ctor and 
> operator=. Possible refactoring like merging all 3 mostly similar 
> visitors into one (or if C++11 is now allowed, use lambda functions 
> instead) are left for later.

Yeah, some refactoring would make this simpler and easier to understand. :)

I applied this patch.

Can you please also write a patch for [1] (source in [2]) to document this?


  reply	other threads:[~2022-06-29 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 16:33 Christian Franke
2022-06-29 13:13 ` Jon Turney [this message]
2022-06-29 15:09   ` Christian Franke
2022-06-29 18:35     ` Christian Franke
2022-07-02 12:35       ` Jon Turney
2022-07-01 17:03     ` Christian Franke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).