From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] gambas3
Date: Mon, 09 Jan 2017 17:29:00 -0000 [thread overview]
Message-ID: <bef25c59-d001-2dda-8e6d-14c08244fa39@dronecode.org.uk> (raw)
In-Reply-To: <ed263940-d918-b1a8-c316-1ad4b70a52a3@fishpost.de>
On 09/01/2017 13:23, Bastian Germann wrote:
> Hi,
>
> I have updated the pending gambas3 package to version 3.9.2.
>
> Some patches from version 3.9.1 are included in mainline and there is a
> new subpackage gambas3-gb-db-odbc now. Nothing else changed regarding
> the packaging.
Thanks for taking this on, and sorry for taking so long to look at it.
A few comments:
* It looks like you are using an older cygport version to build your x86
packages, as it's still generating setup.hint files, please update when
you can)
* The cygport file (possibly) contains some CC-BY-SA licensed content.
This probably bears remarking on, but since we have no policy on the
licensing of the contents of the source package, apart from the upstream
source itself, I guess this is ok.
* 'cygport gambas3.cygport prep' says
> *** Info: applying patch 1:
> patching file gb.db.odbc/src/main.c
> patch unexpectedly ends in middle of line
> Hunk #9 succeeded at 2765 with fuzz 1.
Is this expected? (some artefact of the way cygport is testing the patch?)
Apart from that, it looks good to me.
next prev parent reply other threads:[~2017-01-09 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 13:23 Bastian Germann
2017-01-09 17:29 ` Jon Turney [this message]
2017-01-09 22:07 ` Bastian Germann
-- strict thread matches above, loose matches on Subject: below --
2016-10-04 17:15 Bastian Germann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bef25c59-d001-2dda-8e6d-14c08244fa39@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).