scallyweg: ‘strcasecmp’ was not declared in this scope

scallyweg: ‘strcasecmp’ was not declared in this scope

[Marco Atzeri]

Hi Jon,

I have a strange case with nco

https://github.com/cygwin/scallywag/actions/runs/8060036334/job/22015501908

While Scallyweg complains about ‘strcasecmp’ scope,
local build runs fine.
I saw the same also on previous build

Can you check ?

Regards
Marco

Re: scallyweg: ‘strcasecmp’ was not declared in this scope

[Jon Turney]

On 29/02/2024 06:21, Marco Atzeri via Cygwin-apps wrote:
> Hi Jon,
> 
> I have a strange case with nco
> 
> https://github.com/cygwin/scallywag/actions/runs/8060036334/job/22015501908
> 
> While Scallyweg complains about ‘strcasecmp’ scope,
> local build runs fine.
> I saw the same also on previous build
> 
> Can you check ?

I can reproduce the build failure locally.

 From a brief inspection, this seems to make sense: strcasecmp is 
unconditionally defined by strings.h, which doesn't seem to be included 
anywhere in antlr.

(There's maybe some way it gets indirectly included, maybe via string.h 
if __BSD_VISIBLE, but perhaps that's due to some local flags settings?)

Re: scallyweg: ‘strcasecmp’ was not declared in this scope

[Marco Atzeri]

On 29/02/2024 17:58, Jon Turney wrote:
> On 29/02/2024 06:21, Marco Atzeri via Cygwin-apps wrote:
>> Hi Jon,
>>
>> I have a strange case with nco
>>
>> https://github.com/cygwin/scallywag/actions/runs/8060036334/job/22015501908
>>
>> While Scallyweg complains about ‘strcasecmp’ scope,
>> local build runs fine.
>> I saw the same also on previous build
>>
>> Can you check ?
> 
> I can reproduce the build failure locally.
> 
>  From a brief inspection, this seems to make sense: strcasecmp is 
> unconditionally defined by strings.h, which doesn't seem to be included 
> anywhere in antlr.
> 
> (There's maybe some way it gets indirectly included, maybe via string.h 
> if __BSD_VISIBLE, but perhaps that's due to some local flags settings?)
> 

thanks for double checking

The problem was subtle; the original and ancient

  https://www.antlr2.org/download/antlr-2.7.7.tar.gz

need patching to work with recent compiler.
I had a different version, with the same name, on my computer
but I forgot to update the SRC_URI, so me locally and scallyweg were 
working on different source packages.

Further info on:
https://nco.sourceforge.net/#Source

Regards
Marco

Re: scallyweg: ‘strcasecmp’ was not declared in this scope

[Jon Turney]

On 02/03/2024 17:01, Marco Atzeri via Cygwin-apps wrote:
> On 29/02/2024 17:58, Jon Turney wrote:
>> On 29/02/2024 06:21, Marco Atzeri via Cygwin-apps wrote:
>>> Hi Jon,
>>>
>>> I have a strange case with nco
>>>
>>> https://github.com/cygwin/scallywag/actions/runs/8060036334/job/22015501908
>>>
>>> While Scallyweg complains about ‘strcasecmp’ scope,
>>> local build runs fine.
>>> I saw the same also on previous build
>>>
>>> Can you check ?
>>
>> I can reproduce the build failure locally.
>>
>>  From a brief inspection, this seems to make sense: strcasecmp is 
>> unconditionally defined by strings.h, which doesn't seem to be 
>> included anywhere in antlr.
>>
>> (There's maybe some way it gets indirectly included, maybe via 
>> string.h if __BSD_VISIBLE, but perhaps that's due to some local flags 
>> settings?)
>>
> 
> thanks for double checking

No problem.

> The problem was subtle; the original and ancient
> 
>   https://www.antlr2.org/download/antlr-2.7.7.tar.gz
> 
> need patching to work with recent compiler.
> I had a different version, with the same name, on my computer
> but I forgot to update the SRC_URI, so me locally and scallyweg were 
> working on different source packages.
> 
> Further info on:
> https://nco.sourceforge.net/#Source

Aha! Two archives with the same name but different contents, always great.

There really ought to be a list of hashes for SRC_URI files associated 
with a .cygport file, and cygport should verify them after downloading 
(which would avoid this problem, and related ones), but we've needed 
that feature for a while...