public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Subject: Re: [BUG] mksetupini
Date: Wed, 25 Oct 2017 19:43:00 -0000	[thread overview]
Message-ID: <d81cd088-62b6-ed84-4e6c-e96e62101c37@dronecode.org.uk> (raw)
In-Reply-To: <87mv4fku1r.fsf@Rainer.invalid>

On 25/10/2017 18:37, Achim Gratz wrote:
> Consider the following situation: an old package with setup.hint that
> has dependency to "abc" and a new package version using versioned hint
> files without said dependency.  Not the old package files get deleted,
> but setup.hint stays in the directory.  Running mksetupini correctly
> determines that the setup.hint file needs to be removed, but still
> generates a setup.ini that makes the package depend on "abc".
> 
> The expected behaviour of course would be that it doesn't use the
> information in that file (which no longer exists at the end of the run
> anyway).
   Yeah, this edge case isn't handled correctly:  There's a note in the 
source code [1] that basically says "XXX: do complex stuff here".

I believe If you run mksetupini again, you'll get the correct result, as 
the unneeded setup.hint has been removed.

Since I want to retire setup.hin support fairly soon, I'm not really 
planning on fixing this...

[1] 
https://cygwin.com/git/gitweb.cgi?p=cygwin-apps/calm.git;a=blob;f=calm/package.py;h=ed4cf009ce98c00f9182818353cc454f0c9525b9;hb=HEAD#l875

      reply	other threads:[~2017-10-25 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 17:37 Achim Gratz
2017-10-25 19:43 ` Jon Turney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d81cd088-62b6-ed84-4e6c-e96e62101c37@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).