[ATTN MAINTAINER] mintty

[ATTN MAINTAINER] mintty

[ASSI]

Could you please excise the version check from mintty, at least for the
Cygwin build?  There is no legitimate reason for sending a ping to
Github on each start of mintty.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: [ATTN MAINTAINER] mintty

[Thomas Wolff]

Am 06.06.2020 um 13:31 schrieb ASSI:
> Could you please excise the version check from mintty, at least for the
> Cygwin build?  There is no legitimate reason for sending a ping to
> Github on each start of mintty.
There is no such ping on each start, it's only done when you open the 
Options dialog.
Thomas

Re: [ATTN MAINTAINER] mintty

[ASSI]

Thomas Wolff writes:
> There is no such ping on each start, it's only done when you open the
> Options dialog.

I don't want that to happen just because I open the options dialog
either.  So again, please remove it or put it behind a button that
clearly tells the user what is going to happen.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: [ATTN MAINTAINER] mintty

[Thomas Wolff]

Am 06.06.2020 um 20:43 schrieb ASSI:
> Thomas Wolff writes:
>> There is no such ping on each start, it's only done when you open the
>> Options dialog.
> I don't want that to happen just because I open the options dialog
> either.  So again, please remove it or put it behind a button that
> clearly tells the user what is going to happen.
The version check can be disabled by setting CheckVersionUpdate=0, is 
that sufficient?

Re: [ATTN MAINTAINER] mintty

[Achim Gratz]

Thomas Wolff writes:
> Am 06.06.2020 um 20:43 schrieb ASSI:
>> Thomas Wolff writes:
>>> There is no such ping on each start, it's only done when you open the
>>> Options dialog.
>> I don't want that to happen just because I open the options dialog
>> either.  So again, please remove it or put it behind a button that
>> clearly tells the user what is going to happen.
> The version check can be disabled by setting CheckVersionUpdate=0, is
> that sufficient?

If you make that the default, yes.  :-)


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

Re: [ATTN MAINTAINER] mintty

[Thomas Wolff]

Am 06.06.2020 um 22:09 schrieb Achim Gratz:
> Thomas Wolff writes:
>> Am 06.06.2020 um 20:43 schrieb ASSI:
>>> Thomas Wolff writes:
>>>> There is no such ping on each start, it's only done when you open the
>>>> Options dialog.
>>> I don't want that to happen just because I open the options dialog
>>> either.  So again, please remove it or put it behind a button that
>>> clearly tells the user what is going to happen.
>> The version check can be disabled by setting CheckVersionUpdate=0, is
>> that sufficient?
> If you make that the default, yes.  :-)
Or I could move the check to the About info box. Other opinions?
Thomas

Re: [ATTN MAINTAINER] mintty

[Brian Inglis]

On 2020-06-06 14:09, Achim Gratz wrote:
> Thomas Wolff writes:
>> Am 06.06.2020 um 20:43 schrieb ASSI:
>>> Thomas Wolff writes:

>>>> There is no such ping on each start, it's only done when you open the
>>>> Options dialog.

>>> I don't want that to happen just because I open the options dialog
>>> either.  So again, please remove it or put it behind a button that
>>> clearly tells the user what is going to happen.

>> The version check can be disabled by setting CheckVersionUpdate=0, is
>> that sufficient?

> If you make that the default, yes.  :-)

I can find no mention of this option or action in any announcement: could you
please ensure that new options added do not change existing behaviour as far as
possible, or are clearly documented in the ANNOUNCEMENT and NEWS as breaking
compatibility, and perhaps add a setting for this option at the bottom of the
Options/Terminal dialogue, for those users who wish to enable it.
I probably blocked it in my firewall on first use, so you might also want to
warn users that they could get a firewall prompt.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]

Re: [ATTN MAINTAINER] mintty

[Brian Inglis]

On 2020-06-06 15:43, Thomas Wolff wrote:
> Am 06.06.2020 um 22:09 schrieb Achim Gratz:
>> Thomas Wolff writes:
>>> Am 06.06.2020 um 20:43 schrieb ASSI:
>>>> Thomas Wolff writes:
>>>>> There is no such ping on each start, it's only done when you open the
>>>>> Options dialog.
>>>> I don't want that to happen just because I open the options dialog
>>>> either.  So again, please remove it or put it behind a button that
>>>> clearly tells the user what is going to happen.
>>> The version check can be disabled by setting CheckVersionUpdate=0, is
>>> that sufficient?
>> If you make that the default, yes.  :-)
> Or I could move the check to the About info box. Other opinions?

Add the Enable update check? checkbox setting in the About info box.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]

Re: [ATTN MAINTAINER] mintty

[Thomas Wolff]

Am 06.06.2020 um 23:53 schrieb Brian Inglis:
> On 2020-06-06 14:09, Achim Gratz wrote:
>> Thomas Wolff writes:
>>> Am 06.06.2020 um 20:43 schrieb ASSI:
>>>> Thomas Wolff writes:
>>>>> There is no such ping on each start, it's only done when you open the
>>>>> Options dialog.
>>>> I don't want that to happen just because I open the options dialog
>>>> either.  So again, please remove it or put it behind a button that
>>>> clearly tells the user what is going to happen.
>>> The version check can be disabled by setting CheckVersionUpdate=0, is
>>> that sufficient?
>> If you make that the default, yes.  :-)
> I can find no mention of this option or action in any announcement: could you
> please ensure that new options added do not change existing behaviour as far as
> possible, or are clearly documented in the ANNOUNCEMENT and NEWS as breaking
> compatibility, and perhaps add a setting for this option at the bottom of the
> Options/Terminal dialogue, for those users who wish to enable it.
> I probably blocked it in my firewall on first use, so you might also want to
> warn users that they could get a firewall prompt.
>
It was listed in the change log of release 2.7.5. It's just an HTTP 
request, so I doubt a firewall will speak up.
Anyway, my proposal is to move it to About, which seems to be common 
practice now (Firefox, Thunderbird).
Votes welcome.
Thomas

Re: [ATTN MAINTAINER] mintty

[Achim Gratz]

Thomas Wolff writes:
>> If you make that the default, yes.  :-)
> Or I could move the check to the About info box. Other opinions?

That is better, yes.  But again, the even better option IMHO is to have
a button on a dedicated dialog page that say "Check online on … for
updates.".  That's what LibreOffice does and they do have a configure
option to remove the whole thing when the application is under control
of the system package manager.  That is exactly the situation on Cygwin:
MinTTY is packaged and the information that Github has a new version is
useless anyway.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: [ATTN MAINTAINER] mintty

[Thomas Wolff]

Am 07.06.2020 um 07:52 schrieb Achim Gratz:
> Thomas Wolff writes:
>>> If you make that the default, yes.  :-)
>> Or I could move the check to the About info box. Other opinions?
> That is better, yes.  But again, the even better option IMHO is to have
> a button on a dedicated dialog page that say "Check online on … for
> updates.".  That's what LibreOffice does and they do have a configure
> option to remove the whole thing when the application is under control
> of the system package manager.  That is exactly the situation on Cygwin:
> MinTTY is packaged and the information that Github has a new version is
> useless anyway.
OK, I'm going the easy way and just change the default CheckVersionUpdate=0.
As the current notification (in the Options dialog title) is 
asynchronous (in order not to ever delay mintty by this) and 
asynchronous modification of a MessageBox (as used for the About info) 
is not possible in Windows, moving it there would have become very 
tricky anyway.
Thomas