* adopt and update libatomic_ops and libgc
@ 2017-05-07 12:42 Andy Li
[not found] ` <012a4d1f-6d82-422d-000a-f214a133df56@dronecode.org.uk>
0 siblings, 1 reply; 6+ messages in thread
From: Andy Li @ 2017-05-07 12:42 UTC (permalink / raw)
To: cygwin-apps
Hi,
I would like to adopt and update the now orphaned libatomic_ops and
libgc packages, which is a dependency of the neko package I
maintained.
The updated cygport files can be found at:
https://github.com/andyli/libatomic_ops-cygwin
https://github.com/andyli/libgc-cygwin
Note that I've split them into separated packages, since the source of
libgc no longer contains a copy of atomic_ops, and they are versioned
independently as well.
Please review and let me know if there is anything to improve.
Best regards,
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: adopt and update libatomic_ops and libgc
[not found] ` <012a4d1f-6d82-422d-000a-f214a133df56@dronecode.org.uk>
@ 2017-05-08 14:00 ` Brian Inglis
2017-05-09 5:59 ` Andy Li
0 siblings, 1 reply; 6+ messages in thread
From: Brian Inglis @ 2017-05-08 14:00 UTC (permalink / raw)
To: cygwin-apps; +Cc: Jon Turney
On 2017-05-08 05:54, Jon Turney wrote:
> On 07/05/2017 13:41, Andy Li wrote:
>> I would like to adopt and update the now orphaned libatomic_ops
>> and libgc packages, which is a dependency of the neko package I
>> maintained.
>> The updated cygport files can be found at:
>> https://github.com/andyli/libatomic_ops-cygwin
>> https://github.com/andyli/libgc-cygwin
>> Note that I've split them into separated packages, since the source
>> of libgc no longer contains a copy of atomic_ops, and they are
>> versioned independently as well.
>> Please review and let me know if there is anything to improve.
> Thanks.
> libatomic_ops.cygport:
> A comment that we need to correct for this installing it's
> documentation into usr/share/libatomic_ops, rather that
> usr/share/doc/libatomic_ops might be nice.
> This could alternatively be written using a custom src_install which
> calls cyginstall then moves the directory, which might be less
> brittle to changes in the file list?
> This might be an upstream defect if it doesn't respect --docdir?
> libgc.cygport:
> DEPEND might be better written pkgconfig(atomic_ops)
> Again, stuff installed to usr/share/gc/ should probably be moved to
> usr/share/doc/gc
> I note we also have libgc-7.2d-2 as non-source package, which just
> contains usr/share/doc/Cygwin/libgc.README. That probably needs to
> be cleaned up by being obsoleted.
[was this intended for cygwin-apps?]
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: adopt and update libatomic_ops and libgc
2017-05-08 14:00 ` Brian Inglis
@ 2017-05-09 5:59 ` Andy Li
2017-05-09 9:52 ` Jon Turney
0 siblings, 1 reply; 6+ messages in thread
From: Andy Li @ 2017-05-09 5:59 UTC (permalink / raw)
To: cygwin-apps, Jon Turney
> On 2017-05-08 05:54, Jon Turney wrote:
>> libatomic_ops.cygport:
>> A comment that we need to correct for this installing it's
>> documentation into usr/share/libatomic_ops, rather that
>> usr/share/doc/libatomic_ops might be nice.
>> This could alternatively be written using a custom src_install which
>> calls cyginstall then moves the directory, which might be less
>> brittle to changes in the file list?
>> This might be an upstream defect if it doesn't respect --docdir?
Right, I've just sent a PR to the upstream to fix it. See
https://github.com/ivmai/libatomic_ops/pull/25
I've included it as a patch in the cygport file, which we can remove
in the next version if the PR is merged.
>> libgc.cygport:
>> DEPEND might be better written pkgconfig(atomic_ops)
>> Again, stuff installed to usr/share/gc/ should probably be moved to
>> usr/share/doc/gc
Similarly, the PR: https://github.com/ivmai/bdwgc/pull/161
>> I note we also have libgc-7.2d-2 as non-source package, which just
>> contains usr/share/doc/Cygwin/libgc.README. That probably needs to
>> be cleaned up by being obsoleted.
What is the procedure of obsoleting packages?
Best regards,
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: adopt and update libatomic_ops and libgc
2017-05-09 5:59 ` Andy Li
@ 2017-05-09 9:52 ` Jon Turney
2017-05-11 14:27 ` Andrew Schulman
0 siblings, 1 reply; 6+ messages in thread
From: Jon Turney @ 2017-05-09 9:52 UTC (permalink / raw)
To: cygwin-apps; +Cc: Andy Li
On 09/05/2017 06:59, Andy Li wrote:
>> On 2017-05-08 05:54, Jon Turney wrote:
>>> libatomic_ops.cygport:
>>> A comment that we need to correct for this installing it's
>>> documentation into usr/share/libatomic_ops, rather that
>>> usr/share/doc/libatomic_ops might be nice.
>>> This could alternatively be written using a custom src_install which
>>> calls cyginstall then moves the directory, which might be less
>>> brittle to changes in the file list?
>>> This might be an upstream defect if it doesn't respect --docdir?
>
> Right, I've just sent a PR to the upstream to fix it. See
> https://github.com/ivmai/libatomic_ops/pull/25
> I've included it as a patch in the cygport file, which we can remove
> in the next version if the PR is merged.
>
>>> libgc.cygport:
>>> DEPEND might be better written pkgconfig(atomic_ops)
>>> Again, stuff installed to usr/share/gc/ should probably be moved to
>>> usr/share/doc/gc
>
> Similarly, the PR: https://github.com/ivmai/bdwgc/pull/161
>
>>> I note we also have libgc-7.2d-2 as non-source package, which just
>>> contains usr/share/doc/Cygwin/libgc.README. That probably needs to
>>> be cleaned up by being obsoleted.
>
> What is the procedure of obsoleting packages?
In this case I think you just need:
libgc_devel_OBSOLETES="libgc"
(See https://cygwinports.github.io/cygport/pkg_pkg_cygpart.html#robo445)
I added libatomic_ops and libgc to your package list.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: adopt and update libatomic_ops and libgc
2017-05-09 9:52 ` Jon Turney
@ 2017-05-11 14:27 ` Andrew Schulman
2017-05-11 14:34 ` Andy Li
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Schulman @ 2017-05-11 14:27 UTC (permalink / raw)
To: cygwin-apps
> I added libatomic_ops and libgc to your package list.
Gold stars awarded! https://cygwin.com/goldstars/#AL
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: adopt and update libatomic_ops and libgc
2017-05-11 14:27 ` Andrew Schulman
@ 2017-05-11 14:34 ` Andy Li
0 siblings, 0 replies; 6+ messages in thread
From: Andy Li @ 2017-05-11 14:34 UTC (permalink / raw)
To: cygwin-apps
Oh, that was unexpected! Thank you :D
Best,
Andy
On Thu, May 11, 2017 at 10:27 PM, Andrew Schulman
<schulman.andrew@epa.gov> wrote:
>> I added libatomic_ops and libgc to your package list.
>
> Gold stars awarded! https://cygwin.com/goldstars/#AL
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-11 14:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-07 12:42 adopt and update libatomic_ops and libgc Andy Li
[not found] ` <012a4d1f-6d82-422d-000a-f214a133df56@dronecode.org.uk>
2017-05-08 14:00 ` Brian Inglis
2017-05-09 5:59 ` Andy Li
2017-05-09 9:52 ` Jon Turney
2017-05-11 14:27 ` Andrew Schulman
2017-05-11 14:34 ` Andy Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).