From: Jon Turney <jon.turney@dronecode.org.uk>
To: Christian Franke <Christian.Franke@t-online.de>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [PATCH setup] Add new option --chown-admin
Date: Tue, 23 Aug 2022 16:20:54 +0100 [thread overview]
Message-ID: <e47f723c-fc52-4a34-6476-186ab8890cf9@dronecode.org.uk> (raw)
In-Reply-To: <e69c5ac7-e68e-5df2-41d8-713effd59fdc@dronecode.org.uk>
On 12/07/2022 13:50, Jon Turney wrote:
> [Replying to the right list this time...]
> On 09/07/2022 13:21, Christian Franke wrote:
[...]
>>
>> The UserSettings ctor has a somewhat hidden side effect which sets
>> root_scope correctly:
>>
>> UserSettings::UserSettings(...);
>> open_settings("setup.rc", ...);
>> io_stream::open("cygfile:///etc/setup/setup.rc", ...);
>> io_stream_cygfile::io_stream_cygfile("/etc/setup/setup.rc", ...);
>> get_root_dir_now();
>> read_mounts("");
>> read_mounts_nt("");
>> root_scope = isuser ? IDC_ROOT_USER : IDC_ROOT_SYSTEM;
>>
>> Conclusion: Regression introduced Feb 24, 2012 (befc9dd).
>>
>
> Thanks for tracking this down.
>
> That just seems... fractally wrong.
I kind of lost track of this. Is there anything else needed to fix the
original problem here? Or is it solved by the change to defer setting
the group until after root_scope is known?
next prev parent reply other threads:[~2022-08-23 15:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 7:14 Christian Franke
2022-07-06 13:53 ` Jon Turney
2022-07-06 16:34 ` Christian Franke
2022-07-07 11:38 ` Jon Turney
2022-07-07 14:45 ` Christian Franke
2022-07-07 14:59 ` Christian Franke
[not found] ` <d7d51d1c-f6d5-2fac-3e6d-86714efd0734@dronecode.org.uk>
[not found] ` <32655945-5075-0823-2a1d-b72caa4b7791@t-online.de>
2022-07-12 12:50 ` Jon Turney
2022-08-23 15:20 ` Jon Turney [this message]
2022-08-23 17:27 ` Christian Franke
2022-08-26 13:27 ` Jon Turney
2022-08-26 15:02 ` Christian Franke
2022-08-28 17:33 ` Christian Franke
2022-09-02 13:56 ` Jon Turney
2022-09-02 15:17 ` Christian Franke
2022-09-15 17:45 ` Jon Turney
2022-10-04 12:05 ` Christian Franke
2022-11-29 21:37 ` Jon Turney
2022-11-30 18:49 ` Christian Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e47f723c-fc52-4a34-6476-186ab8890cf9@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Christian.Franke@t-online.de \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).