public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Libor Ukropec <ace@seznam.cz>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] picocom 3.1
Date: Sat, 7 Jan 2023 18:03:56 +0100	[thread overview]
Message-ID: <ed9fbd7a-8e02-5d7a-d9a2-652ec16fea7a@seznam.cz> (raw)
In-Reply-To: <5d5a1cb9-0633-3eb8-7eea-5ab4b9c3f7eb@dronecode.org.uk>

Dne 07.01.2023 v 14:26 Jon Turney via Cygwin-apps napsal(a):
> On 03/01/2023 23:02, Libor Ukropec via Cygwin-apps wrote:

>> HOMEPAGE="hhttps://github.com/npat-efault/picocom"
> 
> There seems to be typo here (a doubled h in hhttps)
good catch, fixed
> 
>> LICENSE="GPL-2.0"
>>
>> # source and patch files
>> SRC_URI="https://github.com/npat-efault/${NAME}/archive/refs/tags/${VERSION}.tar.gz"
>> REQUIRES=""
> 
> You don't need this if it's empty
fixed
> 
>> BUILD_REQUIRES+="gcc-g++"
> 
> This can be written just '='
fixed
> 
>> MAKEOPTS=""
removed, copy&paste error
> 
> Does this do anything?
> 
> Otherwise, looks good. Thanks.
> 
> I added picocom to your packages.
> 
> 
thank you, repo initialized.

  reply	other threads:[~2023-01-07 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03 23:02 Libor Ukropec
2023-01-07 13:26 ` Jon Turney
2023-01-07 17:03   ` Libor Ukropec [this message]
2023-01-07 17:58   ` Jon Turney
2023-01-07 18:59     ` Libor Ukropec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed9fbd7a-8e02-5d7a-d9a2-652ec16fea7a@seznam.cz \
    --to=ace@seznam.cz \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).