From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH setup 0/4] Use a pop-up menu to select chooser view filter
Date: Fri, 26 Aug 2016 14:41:00 -0000 [thread overview]
Message-ID: <efd6ff6f-1fc3-9622-b6e9-5b849747e5e3@dronecode.org.uk> (raw)
In-Reply-To: <20160826080704.GB23935@calimero.vinschen.de>
On 26/08/2016 09:07, Corinna Vinschen wrote:
> On Aug 25 15:34, Yaakov Selkowitz wrote:
>> On 2016-08-25 14:11, Jon Turney wrote:
>>> On 24/08/2016 17:50, Corinna Vinschen wrote:
>>>> One question: Usually the popup menu itself reflects the current choice.
>>>> So, wouldn't it make more sense to have the text "View" just as plain
>>>> text to the left, and the actual popup menu next right to it, showing
>>>> the current choice? Yes? No? Shut up?
>>>
>>> Yeah, there is probably better visual language to be used here.
>>>
>>> If the popup menu itself reflects the current choice, perhaps we don't
>>> need a caption with the current choice at all (i.e. just a button that
>>> says "View" and that's all...)
>>>
>>> I'd really like that button to have a 'â–¾' to indicate it has a
>>> drop-down, but that seems hard to achieve.
>>>
>>> (This might be done with the BS_SPLITBUTTON style (which combines a
>>> button and dropdown menu), but that is sadly only supported by common
>>> controls on Vista or later.)
Two more patches follow this mail, which do that.
I'm still not totally happy with this. It could give the impression
that something is supposed to happen when the "View" part of the the
button is clicked, and there is no keyboard shortcut to open the view
selection menu.
>> We're dropping Cygwin support for XP anyway, so why not from the installer
>> as well?
>
> ACK.
I guess so, if a splitbutton is the right solution.
Should this be done using ld flags --major-os-version 6
--minor-os-version 0? Or some sort of runtime check?
next prev parent reply other threads:[~2016-08-26 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 14:16 Jon Turney
2016-08-24 14:16 ` [PATCH setup 3/4] Rename PickView::Package to PickView::PackagePending Jon Turney
2016-08-24 14:16 ` [PATCH setup 1/4] Build C++ code with -std=gnu++11 Jon Turney
2016-08-24 14:16 ` [PATCH setup 4/4] Use a pop-up menu to directly select chooser view filter Jon Turney
2016-08-24 14:16 ` [PATCH setup 2/4] Change PickView::view into an enum Jon Turney
2016-08-24 16:50 ` [PATCH setup 0/4] Use a pop-up menu to select chooser view filter Corinna Vinschen
2016-08-25 19:11 ` Jon Turney
2016-08-25 20:34 ` Yaakov Selkowitz
2016-08-26 8:07 ` Corinna Vinschen
2016-08-26 14:41 ` Jon Turney [this message]
2016-08-26 14:43 ` [PATCH setup 5/6] Simplify view mode indication Jon Turney
2016-08-26 14:43 ` [PATCH setup 6/6] Use a splitbutton to show the view choosing popup menu Jon Turney
2016-08-26 15:25 ` [PATCH setup 0/4] Use a pop-up menu to select chooser view filter Corinna Vinschen
2016-08-29 10:03 ` Jon Turney
2016-08-29 10:04 ` [PATCH setup 4/4] Use a drop-down list to directly " Jon Turney
2016-08-30 13:01 ` Corinna Vinschen
2016-08-30 23:29 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd6ff6f-1fc3-9622-b6e9-5b849747e5e3@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).