public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Daisuke Fujimura <booleanlabel@gmail.com>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITA] ruby 3.2.2
Date: Sun, 23 Apr 2023 14:35:20 +0100	[thread overview]
Message-ID: <fc8004a1-ce4d-4646-d6ea-c42ceb8480da@dronecode.org.uk> (raw)
In-Reply-To: <CAA3frXQx4SK=N+zvJLErTkO9pffDwfTF9qC=oViRBPjGWvoagQ@mail.gmail.com>

On 22/04/2023 13:04, Daisuke Fujimura via Cygwin-apps wrote:
>>>>>> Are you planning to adopt also the ruby-* sub-packages ?
> 
> I intend to do that.
> 
> 
>>> 2. Modify cygport and release it.
>>>       - Add code to detect dependencies on `ruby_xy`.
>>>       - It is similar to the process for `perl5_xy0`.
>>>           - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.cygpart#L442
>>>           - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.cygpart#L639
>>
>> Yes.
>>
>> I'm not asking you to do this work though, unless you really feel like it :)
> 
> Please review the attached diff.

That looks like almost exactly what's needed.

Thank you very much for that!

>>>       - Add `ruby_PROVIDES="ruby_${${VERSION%.*}//./}"` to ruby.cygport.
> 
> ```
> /tmp/cygport-ruby/ruby.cygport: line 49: ${${VERSION%.*}//./}: bad substitution
> ```
> 
> Is the warning being displayed because $VERSION (=3.2.2) starts with a number?

This is what I get for not trying these things.  I think nesting the 
substitution like that isn't valid in bash, so maybe:

SOVERSION=${VERSION%.*}
ruby_PROVIDES="ruby_${SOVERSION//./}"

actually works?


  reply	other threads:[~2023-04-23 13:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 22:42 Daisuke Fujimura
2023-04-20  3:28 ` Marco Atzeri
2023-04-20 10:50   ` Jon Turney
2023-04-20 16:13     ` Jon Turney
2023-04-21 19:36       ` Daisuke Fujimura
2023-04-21 20:06         ` Jon Turney
2023-04-22 12:04           ` Daisuke Fujimura
2023-04-23 13:35             ` Jon Turney [this message]
2023-04-23 23:44               ` Daisuke Fujimura
2023-04-24 20:10                 ` Jon Turney
2023-04-25  9:56                   ` Daisuke Fujimura
2023-04-25 13:52                     ` Jon Turney
2023-04-25 21:10                       ` Daisuke Fujimura
2023-04-25 22:13                         ` Jon Turney
2023-04-25 22:37                           ` Daisuke Fujimura
2023-06-08 14:38 ` [GOLDSTAR] " Jon Turney
2023-06-13 15:04   ` Andrew Schulman
2023-06-13 23:24     ` Daisuke Fujimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc8004a1-ce4d-4646-d6ea-c42ceb8480da@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=booleanlabel@gmail.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).