Re: [ITP] openh264 (2.3.1)

[Jon Turney <jon.turney@dronecode.org.uk>]

On 22/02/2023 03:33, Takashi Yano via Cygwin-apps wrote:
> On Tue, 21 Feb 2023 14:11:46 +0000
> Jon Turney wrote:
>> On 20/02/2023 08:55, Takashi Yano via Cygwin-apps wrote:
>>> On Sun, 19 Feb 2023 15:37:47 +0000
>>> Jon Turney wrote:
>> [...]>> * I don't think you should need:
>>>>
>>>>> 	# Install postinstall/preremove scripts
>>>>> 	mkdir -p ${D}/etc/postinstall  ${D}/etc/preremove
>>>>> 	cp ${C}/lib${NAME}.postinstall ${D}/etc/postinstall/lib${NAME}.sh
>>>>> 	cp ${C}/lib${NAME}.preremove ${D}/etc/preremove/lib${NAME}.sh
>>>>>
>>>>
>>>> This should happen automatically if the files are in $C (and you can
>>>> list them in CYGWIN_FILES or make them with cygwin.patch file to put
>>>> them there)
>>>
>>> That's what I understood from
>>> https://cygwin.github.io/cygport/masterindex.html,
>>> however, actually libopenh264.{postinstall,preremove} are
>>> not installed during install process by cygport 0.36.0
>>> even though openh264-2.3.1-1.cygwin.patch exists.
>>>
>>> Could you please give me a hint how I can make it work?
>>
>> Aha! This is a bug in cygport.
>>
>> (There's some code which skips over doing this for the first item in
>> PKG_NAMES, assuming that is always the same as PN, which has already
>> been done)
>>
>> Thanks for drawing that to my attention. I'll look into fixing it, but
>> for the moment it seems you can workaround the bug by ensuring that the
>> package with premove/postinstall scripts isn't first in that list, i.e.:
>>
>> - PKG_NAMES="libopenh264 libopenh264-headers"
>> + PKG_NAMES="libopenh264-headers libopenh264"
> 
> Thanks! It works.
> 
> I updated the cygport file and cygwin.patch.

GTG.