public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: pty: Fix a bug regarding ESC[?3h and ESC[?3l handling.
@ 2019-12-18 19:25 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2019-12-18 19:25 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=fe512b2b12a2cea8393d14f038dc3914b1bf3f60
commit fe512b2b12a2cea8393d14f038dc3914b1bf3f60
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date: Thu Dec 19 01:07:33 2019 +0900
Cygwin: pty: Fix a bug regarding ESC[?3h and ESC[?3l handling.
- Midnight commander (mc) does not work after the commit
1626569222066ee601f6c41b29efcc95202674b7 as reported in
https://www.cygwin.com/ml/cygwin/2019-12/msg00173.html.
This patch fixes the issue.
Diff:
---
winsup/cygwin/fhandler_tty.cc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 1d344c7..8c3a6e7 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1262,16 +1262,19 @@ fhandler_pty_slave::push_to_pcon_screenbuffer (const char *ptr, size_t len)
while ((p0 = (char *) memmem (p0, nlen - (p0 - buf), "\033[?", 3)))
{
p0 += 3;
- while (p0 < buf + nlen && *p0 != 'h' && *p0 != 'l')
+ bool exist_arg_3 = false;
+ while (p0 < buf + nlen && !isalpha (*p0))
{
int arg = 0;
while (p0 < buf + nlen && isdigit (*p0))
arg = arg * 10 + (*p0 ++) - '0';
if (arg == 3)
- get_ttyp ()->need_redraw_screen = true;
+ exist_arg_3 = true;
if (p0 < buf + nlen && *p0 == ';')
p0 ++;
}
+ if (p0 < buf + nlen && exist_arg_3 && (*p0 == 'h' || *p0 == 'l'))
+ get_ttyp ()->need_redraw_screen = true;
p0 ++;
if (p0 >= buf + nlen)
break;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-18 19:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 19:25 [newlib-cygwin] Cygwin: pty: Fix a bug regarding ESC[?3h and ESC[?3l handling Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).