public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: Speed up dumper
@ 2020-07-31 13:01 Jon TURNEY
  0 siblings, 0 replies; only message in thread
From: Jon TURNEY @ 2020-07-31 13:01 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c222c1b294c7d6e2b0e554aa2fbde79c8b768594

commit c222c1b294c7d6e2b0e554aa2fbde79c8b768594
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Mon Jul 6 15:10:40 2020 +0100

    Cygwin: Speed up dumper
    
    Stop after we've written the dump in response to the initial breakpoint
    EXCEPTION_DEBUG_EVENT we recieve for attaching to the process.
    
    (rather than bogusly sitting there for 20 seconds waiting for more debug
    events from a stopped process after we've already written the dump).

Diff:
---
 winsup/utils/dumper.cc | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/winsup/utils/dumper.cc b/winsup/utils/dumper.cc
index 816320e6d..5f8121aa3 100644
--- a/winsup/utils/dumper.cc
+++ b/winsup/utils/dumper.cc
@@ -615,8 +615,6 @@ out:
 int
 dumper::collect_process_information ()
 {
-  int exception_level = 0;
-
   if (!sane ())
     return 0;
 
@@ -631,7 +629,7 @@ dumper::collect_process_information ()
 
   while (1)
     {
-      if (!WaitForDebugEvent (&current_event, 20000))
+      if (!WaitForDebugEvent (&current_event, INFINITE))
 	return 0;
 
       deb_printf ("got debug event %d\n", current_event.dwDebugEventCode);
@@ -675,12 +673,6 @@ dumper::collect_process_information ()
 
 	case EXCEPTION_DEBUG_EVENT:
 
-	  exception_level++;
-	  if (exception_level == 2)
-	    break;
-	  else if (exception_level > 2)
-	    return 0;
-
 	  collect_memory_sections ();
 
 	  /* got all info. time to dump */
@@ -697,6 +689,9 @@ dumper::collect_process_information ()
 	      goto failed;
 	    };
 
+	  /* We're done */
+	  goto failed;
+
 	  break;
 
 	default:


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-07-31 13:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31 13:01 [newlib-cygwin] Cygwin: Speed up dumper Jon TURNEY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).