public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: sigproc: return int from remove_proc Date: Fri, 28 Aug 2020 13:23:49 +0000 (GMT) [thread overview] Message-ID: <20200828132349.6F2813861002@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=eb3e3e47385790db463b341f47e0ca4b7b2f8dcb commit eb3e3e47385790db463b341f47e0ca4b7b2f8dcb Author: Corinna Vinschen <corinna@vinschen.de> Date: Thu Aug 27 21:48:54 2020 +0200 Cygwin: sigproc: return int from remove_proc The return value is used in a numerical context and remove_proc already returned inconsistently "true" vs. 0. Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/sigproc.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc index b29835ee6..86c0aa11b 100644 --- a/winsup/cygwin/sigproc.cc +++ b/winsup/cygwin/sigproc.cc @@ -63,7 +63,7 @@ HANDLE NO_COPY my_pendingsigs_evt; /* Function declarations */ static int __reg1 checkstate (waitq *); static __inline__ bool get_proc_lock (DWORD, DWORD); -static bool __stdcall remove_proc (int); +static int __stdcall remove_proc (int); static bool __stdcall stopped_or_terminated (waitq *, _pinfo *); static void WINAPI wait_sig (VOID *arg); @@ -1153,7 +1153,7 @@ out: /* Remove a proc from procs by swapping it with the last child in the list. Also releases shared memory of exited processes. */ -static bool __stdcall +static int __stdcall remove_proc (int ci) { if (have_execed) @@ -1162,7 +1162,7 @@ remove_proc (int ci) procs[ci].wait_thread->terminate_thread (); } else if (procs[ci] && procs[ci]->exists ()) - return true; + return 1; sigproc_printf ("removing procs[%d], pid %d, nprocs %d", ci, procs[ci]->pid, nprocs);
reply other threads:[~2020-08-28 13:23 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200828132349.6F2813861002@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).