public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: sigproc: return int from remove_proc
@ 2020-08-28 13:23 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2020-08-28 13:23 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=eb3e3e47385790db463b341f47e0ca4b7b2f8dcb

commit eb3e3e47385790db463b341f47e0ca4b7b2f8dcb
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Thu Aug 27 21:48:54 2020 +0200

    Cygwin: sigproc: return int from remove_proc
    
    The return value is used in a numerical context and remove_proc
    already returned inconsistently "true" vs. 0.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/sigproc.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index b29835ee6..86c0aa11b 100644
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -63,7 +63,7 @@ HANDLE NO_COPY my_pendingsigs_evt;
 /* Function declarations */
 static int __reg1 checkstate (waitq *);
 static __inline__ bool get_proc_lock (DWORD, DWORD);
-static bool __stdcall remove_proc (int);
+static int __stdcall remove_proc (int);
 static bool __stdcall stopped_or_terminated (waitq *, _pinfo *);
 static void WINAPI wait_sig (VOID *arg);
 
@@ -1153,7 +1153,7 @@ out:
 
 /* Remove a proc from procs by swapping it with the last child in the list.
    Also releases shared memory of exited processes.  */
-static bool __stdcall
+static int __stdcall
 remove_proc (int ci)
 {
   if (have_execed)
@@ -1162,7 +1162,7 @@ remove_proc (int ci)
 	procs[ci].wait_thread->terminate_thread ();
     }
   else if (procs[ci] && procs[ci]->exists ())
-    return true;
+    return 1;
 
   sigproc_printf ("removing procs[%d], pid %d, nprocs %d", ci, procs[ci]->pid,
 		  nprocs);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-28 13:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 13:23 [newlib-cygwin] Cygwin: sigproc: return int from remove_proc Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).