public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: path_conv::eq_worker: add NULL pointer checks
@ 2020-11-16 13:40 Ken Brown
0 siblings, 0 replies; only message in thread
From: Ken Brown @ 2020-11-16 13:40 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=22d1ebacfc5a1d3596d5dc25c2464fa51ed58944
commit 22d1ebacfc5a1d3596d5dc25c2464fa51ed58944
Author: Ken Brown <kbrown@cornell.edu>
Date: Sat Nov 14 09:02:43 2020 -0500
Cygwin: path_conv::eq_worker: add NULL pointer checks
Don't call cstrdup on NULL pointers.
This fixes a crash that was observed when cloning an fhandler whose
path_conv member had freed its strings.
Diff:
---
winsup/cygwin/path.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/path.h b/winsup/cygwin/path.h
index b94f13df8..0b3e72fc1 100644
--- a/winsup/cygwin/path.h
+++ b/winsup/cygwin/path.h
@@ -320,9 +320,11 @@ class path_conv
contrast to statically allocated strings. Calling device::dup()
will duplicate the string if the source was allocated. */
dev.dup ();
- path = cstrdup (in_path);
+ if (in_path)
+ path = cstrdup (in_path);
conv_handle.dup (pc.conv_handle);
- posix_path = cstrdup(pc.posix_path);
+ if (pc.posix_path)
+ posix_path = cstrdup(pc.posix_path);
if (pc.wide_path)
{
wide_path = cwcsdup (uni_path.Buffer);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-16 13:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 13:40 [newlib-cygwin] Cygwin: path_conv::eq_worker: add NULL pointer checks Ken Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).