public inbox for
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: chown: make sure ctime gets updated when necessary
@ 2021-01-26 14:37 Ken Brown
  0 siblings, 0 replies; only message in thread
From: Ken Brown @ 2021-01-26 14:37 UTC (permalink / raw)
  To: cygwin-cvs;h=b32f6dd40a2764aed1baec35da0a7512f3fbceb3

commit b32f6dd40a2764aed1baec35da0a7512f3fbceb3
Author: Ken Brown <>
Date:   Mon Jan 25 21:05:37 2021 -0500

    Cygwin: chown: make sure ctime gets updated when necessary
    Following POSIX, ensure that ctime is updated if chown succeeds,
    unless the new owner is specified as (uid_t)-1 and the new group is
    specified as (gid_t)-1.  Previously, ctime was unchanged whenever the
    owner and group were both unchanged.
    Aside from POSIX compliance, this fix makes gnulib report that chown
    works on Cygwin.  This improves the efficiency of packages like GNU
    tar that use gnulib's chown module.  Previously such packages would
    use a gnulib replacement for chown on Cygwin.

 winsup/cygwin/ | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 07f9c513a..5e58688b7 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -887,15 +887,18 @@ fhandler_disk_file::fchown (uid_t uid, gid_t gid)
 				    aclp, MAX_ACL_ENTRIES)) < 0)
     goto out;
-  if (uid == ILLEGAL_UID)
-    uid = old_uid;
-  if (gid == ILLEGAL_GID)
-    gid = old_gid;
-  if (uid == old_uid && gid == old_gid)
+  /* According to POSIX, chown can be a no-op if uid is (uid_t)-1 and
+     gid is (gid_t)-1.  Otherwise, even if uid and gid are unchanged,
+     we must ensure that ctime is updated. */
+  if (uid == ILLEGAL_UID && gid == ILLEGAL_GID)
       ret = 0;
       goto out;
+  if (uid == ILLEGAL_UID)
+    uid = old_uid;
+  else if (gid == ILLEGAL_GID)
+    gid = old_gid;
   /* Windows ACLs can contain permissions for one group, while being owned by
      another user/group.  The permission bits returned above are pretty much

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-26 14:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 14:37 [newlib-cygwin] Cygwin: chown: make sure ctime gets updated when necessary Ken Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).