public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: console: Align the behaviour against signal with pty.
Date: Mon,  1 Feb 2021 10:01:28 +0000 (GMT)	[thread overview]
Message-ID: <20210201100128.152EA385040E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6ab2d284e54384cc6e7dc13eed1eddd12bd77879

commit 6ab2d284e54384cc6e7dc13eed1eddd12bd77879
Author: Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com>
Date:   Fri Jan 29 12:45:44 2021 +0900

    Cygwin: console: Align the behaviour against signal with pty.
    
    - Currently, read() returns -1 with EINTR if the process is suspended
      by Ctrl-Z and resumed by fg command, while pty continues to read.
      For example, xxd command stops with error "Interrupted system call"
      after Ctrl-Z and fg. This patch aligns the behaviour with pty (and
      Linux).

Diff:
---
 winsup/cygwin/fhandler_console.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 0b404411e..3c0783575 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -587,7 +587,8 @@ wait_retry:
 	  break;
 	case input_signalled: /* signalled */
 	  release_input_mutex ();
-	  goto sig_exit;
+	  /* The signal will be handled by cygwait() above. */
+	  continue;
 	case input_winch:
 	  release_input_mutex ();
 	  continue;


                 reply	other threads:[~2021-02-01 10:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201100128.152EA385040E@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).