public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: console: Align the behaviour against signal with pty.
@ 2021-02-01 10:01 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2021-02-01 10:01 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6ab2d284e54384cc6e7dc13eed1eddd12bd77879
commit 6ab2d284e54384cc6e7dc13eed1eddd12bd77879
Author: Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com>
Date: Fri Jan 29 12:45:44 2021 +0900
Cygwin: console: Align the behaviour against signal with pty.
- Currently, read() returns -1 with EINTR if the process is suspended
by Ctrl-Z and resumed by fg command, while pty continues to read.
For example, xxd command stops with error "Interrupted system call"
after Ctrl-Z and fg. This patch aligns the behaviour with pty (and
Linux).
Diff:
---
winsup/cygwin/fhandler_console.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 0b404411e..3c0783575 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -587,7 +587,8 @@ wait_retry:
break;
case input_signalled: /* signalled */
release_input_mutex ();
- goto sig_exit;
+ /* The signal will be handled by cygwait() above. */
+ continue;
case input_winch:
release_input_mutex ();
continue;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-01 10:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 10:01 [newlib-cygwin] Cygwin: console: Align the behaviour against signal with pty Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).