public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: console: Prevent NULL pointer access in close(). Date: Mon, 22 Feb 2021 13:58:19 +0000 (GMT) [thread overview] Message-ID: <20210222135819.BED54389682E@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6cde7279a00452ed1ccc0ffc39d9011b016fadb3 commit 6cde7279a00452ed1ccc0ffc39d9011b016fadb3 Author: Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com> Date: Mon Feb 22 22:30:17 2021 +0900 Cygwin: console: Prevent NULL pointer access in close(). - There seems to be a case that shared_console_info is not set yet when close() is called. This patch adds guard for such case. Diff: --- winsup/cygwin/fhandler_console.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc index 6ded9eabf..96a8729e8 100644 --- a/winsup/cygwin/fhandler_console.cc +++ b/winsup/cygwin/fhandler_console.cc @@ -1393,7 +1393,7 @@ fhandler_console::close () release_output_mutex (); - if (con.owner == myself->pid) + if (shared_console_info && con.owner == myself->pid) { char name[MAX_PATH]; shared_name (name, CONS_THREAD_SYNC, get_minor ());
reply other threads:[~2021-02-22 13:58 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210222135819.BED54389682E@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).