public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon.
@ 2021-03-08 14:02 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2021-03-08 14:02 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=850b5a9aae49a9a0fa21d3ace385e8d6b03ae285
commit 850b5a9aae49a9a0fa21d3ace385e8d6b03ae285
Author: Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com>
Date: Mon Mar 8 22:14:58 2021 +0900
Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon.
- If two non-cygwin apps are started simultaneously, attaching to
pseudo console sometimes fails. This is because the second app
trys to attach to the process not started yet. This patch avoids
the issue by attaching to the stub process rather than the other
non-cygwin app.
Diff:
---
winsup/cygwin/fhandler_tty.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 4358bceec..3bfc8c0c8 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -3104,7 +3104,7 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
0, TRUE, DUPLICATE_SAME_ACCESS);
CloseHandle (pcon_owner);
FreeConsole ();
- AttachConsole (p->dwProcessId);
+ AttachConsole (p->exec_dwProcessId);
goto skip_create;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-08 14:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 14:02 [newlib-cygwin] Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).