public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: dup: fix handle inheritence for disk file pread/pwrite handle
Date: Mon, 30 Aug 2021 19:57:14 +0000 (GMT)	[thread overview]
Message-ID: <20210830195714.C60B63858D34@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=9069cb91710d55735af5115681712ba4c2894276

commit 9069cb91710d55735af5115681712ba4c2894276
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Aug 30 21:56:33 2021 +0200

    Cygwin: dup: fix handle inheritence for disk file pread/pwrite handle
    
    The handle is created non-inheritable but gets inheritable when
    dup'ing the file descriptor.  Fix that.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler_disk_file.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc
index 6170427b0..33d885819 100644
--- a/winsup/cygwin/fhandler_disk_file.cc
+++ b/winsup/cygwin/fhandler_disk_file.cc
@@ -1444,7 +1444,7 @@ fhandler_disk_file::dup (fhandler_base *child, int flags)
   if (!ret && prw_handle
       && !DuplicateHandle (GetCurrentProcess (), prw_handle,
 			   GetCurrentProcess (), &fhc->prw_handle,
-			   0, TRUE, DUPLICATE_SAME_ACCESS))
+			   0, FALSE, DUPLICATE_SAME_ACCESS))
     fhc->prw_handle = NULL;
   return ret;
 }


                 reply	other threads:[~2021-08-30 19:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830195714.C60B63858D34@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).