public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Ken Brown <kbrown@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: fhandler_pipe::open_setup: fail on error creating mutexes Date: Mon, 20 Sep 2021 19:10:34 +0000 (GMT) [thread overview] Message-ID: <20210920191034.7A89C3858412@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6fc0aa8e5d6cd7e344afc967d30253ed40541843 commit 6fc0aa8e5d6cd7e344afc967d30253ed40541843 Author: Ken Brown <kbrown@cornell.edu> Date: Sat Sep 18 08:34:04 2021 -0400 Cygwin: fhandler_pipe::open_setup: fail on error creating mutexes Diff: --- winsup/cygwin/fhandler_pipe.cc | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc index 590ecf667..449e268ab 100644 --- a/winsup/cygwin/fhandler_pipe.cc +++ b/winsup/cygwin/fhandler_pipe.cc @@ -194,26 +194,39 @@ out: bool fhandler_pipe::open_setup (int flags) { + bool read_mtx_created = false; + if (!fhandler_base::open_setup (flags)) goto err; if (get_dev () == FH_PIPER && !read_mtx) { SECURITY_ATTRIBUTES *sa = sec_none_cloexec (flags); read_mtx = CreateMutex (sa, FALSE, NULL); - if (!read_mtx) - debug_printf ("CreateMutex read_mtx failed: %E"); + if (read_mtx) + read_mtx_created = true; + else + { + debug_printf ("CreateMutex read_mtx failed: %E"); + goto err; + } } if (!hdl_cnt_mtx) { SECURITY_ATTRIBUTES *sa = sec_none_cloexec (flags); hdl_cnt_mtx = CreateMutex (sa, FALSE, NULL); if (!hdl_cnt_mtx) - debug_printf ("CreateMutex hdl_cnt_mtx failed: %E"); + { + debug_printf ("CreateMutex hdl_cnt_mtx failed: %E"); + goto err_close_read_mtx; + } } if (get_dev () == FH_PIPEW && !query_hdl) set_pipe_non_blocking (is_nonblocking ()); return true; +err_close_read_mtx: + if (read_mtx_created) + CloseHandle (read_mtx); err: return false; }
reply other threads:[~2021-09-20 19:10 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210920191034.7A89C3858412@sourceware.org \ --to=kbrown@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).