public inbox for
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: pty: Prevent deadlock on echo output.
@ 2022-02-13 15:18 Takashi Yano
  0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2022-02-13 15:18 UTC (permalink / raw)
  To: cygwin-cvs;h=bddd9c1c417e97791c44241cf94753e90464501c

commit bddd9c1c417e97791c44241cf94753e90464501c
Author: Takashi Yano <>
Date:   Thu Feb 10 17:22:11 2022 +0900

    Cygwin: pty: Prevent deadlock on echo output.
    - If the slave process writes a lot of text output, doecho() can
      cause deadlock. This is because output_mutex is held in slave::
      write() and if WriteFile() is blocked due to pipe full, doecho()
      tries to acquire output_mutex and gets into deadlock. With this
      patch, the deadlock is prevented on the sacrifice of atomicity
      of doecho().

 winsup/cygwin/ | 2 --
 1 file changed, 2 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 7bef6958c..7e065c46a 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -496,11 +496,9 @@ void
 fhandler_pty_master::doecho (const void *str, DWORD len)
   ssize_t towrite = len;
-  acquire_output_mutex (mutex_timeout);
   if (!process_opost_output (echo_w, str, towrite, true,
 			     get_ttyp (), is_nonblocking ()))
     termios_printf ("Write to echo pipe failed, %E");
-  release_output_mutex ();

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-13 15:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 15:18 [newlib-cygwin] Cygwin: pty: Prevent deadlock on echo output Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).